From 585c7b047477bd25575ff19ca1abc2cc56136c6e Mon Sep 17 00:00:00 2001 From: voommen-livefront Date: Fri, 9 May 2025 13:26:56 -0500 Subject: [PATCH] PM-20577 fixed failing unit tests --- .../services/risk-insights-api.service.ts | 2 +- .../services/risk-insights-report.service.spec.ts | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/risk-insights-api.service.ts b/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/risk-insights-api.service.ts index 786ffbc3722..25212ee0216 100644 --- a/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/risk-insights-api.service.ts +++ b/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/risk-insights-api.service.ts @@ -27,7 +27,7 @@ export class RiskInsightsApiService { return from(dbResponse as Promise); } - getRiskInsightsReport(orgId: OrganizationId): Observable { + getRiskInsightsReport(orgId: OrganizationId): Observable { const dbResponse = this.apiService .send("GET", `/reports/risk-insights-report/${orgId.toString()}`, null, true, true) .catch((error: any): any => { diff --git a/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/risk-insights-report.service.spec.ts b/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/risk-insights-report.service.spec.ts index 705eb1231a9..fed9cc4856b 100644 --- a/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/risk-insights-report.service.spec.ts +++ b/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/risk-insights-report.service.spec.ts @@ -3,10 +3,14 @@ import { firstValueFrom } from "rxjs"; import { ZXCVBNResult } from "zxcvbn"; import { AuditService } from "@bitwarden/common/abstractions/audit.service"; +import { EncryptService } from "@bitwarden/common/key-management/crypto/abstractions/encrypt.service"; +import { KeyGenerationService } from "@bitwarden/common/platform/abstractions/key-generation.service"; import { PasswordStrengthServiceAbstraction } from "@bitwarden/common/tools/password-strength"; import { CipherService } from "@bitwarden/common/vault/abstractions/cipher.service"; +import { KeyService } from "@bitwarden/key-management"; import { mockCiphers } from "./ciphers.mock"; +import { CriticalAppsService } from "./critical-apps.service"; import { MemberCipherDetailsApiService } from "./member-cipher-details-api.service"; import { mockMemberCipherDetails } from "./member-cipher-details-api.service.spec"; import { RiskInsightsReportService } from "./risk-insights-report.service"; @@ -17,6 +21,10 @@ describe("RiskInsightsReportService", () => { const auditService = mock(); const cipherService = mock(); const memberCipherDetailsService = mock(); + const keyService = mock(); + const encryptService = mock(); + const criticalAppsService = mock(); + const keyGenerationService = mock(); beforeEach(() => { pwdStrengthService.getPasswordStrength.mockImplementation((password: string) => { @@ -37,6 +45,10 @@ describe("RiskInsightsReportService", () => { auditService, cipherService, memberCipherDetailsService, + keyService, + encryptService, + criticalAppsService, + keyGenerationService, ); });