From 59169fb0c7c301859a1b7f7dcb12235cb972861f Mon Sep 17 00:00:00 2001 From: Daniel Riera Date: Fri, 15 Aug 2025 12:16:52 -0400 Subject: [PATCH] PM-23976 Autofilling not working in https://www.sketchup.com (#15990) * PM-23976 * add space --- .../browser/src/autofill/services/autofill.service.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/apps/browser/src/autofill/services/autofill.service.ts b/apps/browser/src/autofill/services/autofill.service.ts index 099f345cb75..fd707ef96b3 100644 --- a/apps/browser/src/autofill/services/autofill.service.ts +++ b/apps/browser/src/autofill/services/autofill.service.ts @@ -2459,22 +2459,23 @@ export default class AutofillService implements AutofillServiceInterface { break; } + const includesUsernameFieldName = + this.findMatchingFieldIndex(f, AutoFillConstants.UsernameFieldNames) > -1; + if ( !f.disabled && (canBeReadOnly || !f.readonly) && - (withoutForm || f.form === passwordField.form) && + (withoutForm || f.form === passwordField.form || includesUsernameFieldName) && (canBeHidden || f.viewable) && (f.type === "text" || f.type === "email" || f.type === "tel") ) { usernameField = f; - - if (this.findMatchingFieldIndex(f, AutoFillConstants.UsernameFieldNames) > -1) { - // We found an exact match. No need to keep looking. + // We found an exact match. No need to keep looking. + if (includesUsernameFieldName) { break; } } } - return usernameField; }