mirror of
https://github.com/bitwarden/browser
synced 2025-12-21 02:33:46 +00:00
[PM-14571] At Risk Passwords - Badge Update (#15983)
* add exclamation badge for at risk passwords on tab
* add berry icon for the badge when pending tasks are present
* remove integration wtih autofill for pending task badge
* add ability to override Never match strategy
- This is helpful for non-autofill purposes but cipher matching is still needed. This will default to the domain.
* add at-risk-cipher badge updater service
* Revert "add exclamation badge for at risk passwords on tab"
This reverts commit a9643c03d5.
* remove nullish-coalescing
* ensure that all user related observables use the same user.id
---------
Co-authored-by: Shane Melton <smelton@bitwarden.com>
This commit is contained in:
@@ -601,6 +601,7 @@ export class CipherService implements CipherServiceAbstraction {
|
||||
userId: UserId,
|
||||
includeOtherTypes?: CipherType[],
|
||||
defaultMatch: UriMatchStrategySetting = null,
|
||||
overrideNeverMatchStrategy?: true,
|
||||
): Promise<CipherView[]> {
|
||||
return await firstValueFrom(
|
||||
this.cipherViews$(userId).pipe(
|
||||
@@ -612,6 +613,7 @@ export class CipherService implements CipherServiceAbstraction {
|
||||
url,
|
||||
includeOtherTypes,
|
||||
defaultMatch,
|
||||
overrideNeverMatchStrategy,
|
||||
),
|
||||
),
|
||||
),
|
||||
@@ -623,6 +625,7 @@ export class CipherService implements CipherServiceAbstraction {
|
||||
url: string,
|
||||
includeOtherTypes?: CipherType[],
|
||||
defaultMatch: UriMatchStrategySetting = null,
|
||||
overrideNeverMatchStrategy?: true,
|
||||
): Promise<C[]> {
|
||||
if (url == null && includeOtherTypes == null) {
|
||||
return [];
|
||||
@@ -647,7 +650,13 @@ export class CipherService implements CipherServiceAbstraction {
|
||||
}
|
||||
|
||||
if (cipherIsLogin) {
|
||||
return CipherViewLikeUtils.matchesUri(cipher, url, equivalentDomains, defaultMatch);
|
||||
return CipherViewLikeUtils.matchesUri(
|
||||
cipher,
|
||||
url,
|
||||
equivalentDomains,
|
||||
defaultMatch,
|
||||
overrideNeverMatchStrategy,
|
||||
);
|
||||
}
|
||||
|
||||
return false;
|
||||
|
||||
Reference in New Issue
Block a user