bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-15 07:43:35 +00:00
Code Issues Releases Wiki Activity

[EC-772] Add i18n key typechecking in web (#4023)

Browse Source
This commit is contained in:
Thomas Rittson
2022-12-21 14:27:00 +10:00
committed by GitHub
parent b331f5b329
commit 5a1940f3f4
50 changed files with 176 additions and 109 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libs/common/src/abstractions/i18n.service.ts
View File

@@ -1,11 +1,11 @@
import { Observable } from "rxjs";
export abstract class I18nService {
export abstract class I18nService<TKey = string> {
locale$: Observable<string>;
supportedTranslationLocales: string[];
translationLocale: string;
collator: Intl.Collator;
localeNames: Map<string, string>;
t: (id: string, p1?: string | number, p2?: string | number, p3?: string | number) => string;
translate: (id: string, p1?: string, p2?: string, p3?: string) => string;
t: (id: TKey, p1?: string | number, p2?: string | number, p3?: string | number) => string;
translate: (id: TKey, p1?: string, p2?: string, p3?: string) => string;
}

8
libs/common/src/models/response/plan.response.ts
View File

@@ -8,8 +8,12 @@ export class PlanResponse extends BaseResponse {
product: ProductType;
name: string;
isAnnual: boolean;
nameLocalizationKey: string;
descriptionLocalizationKey: string;
nameLocalizationKey: "planNameFree" | "planNameFamilies" | "planNameTeams" | "planNameEnterprise";
descriptionLocalizationKey:
| "planDescFree"
| "planDescFamilies"
| "planDescTeams"
| "planDescEnterprise";
canBeUsedByBusiness: boolean;
baseSeats: number;
baseStorageGb: number;

2
libs/common/src/models/response/subscription.response.ts
View File

@@ -60,7 +60,7 @@ export class BillingSubscriptionItemResponse extends BaseResponse {
name: string;
amount: number;
quantity: number;
interval: string;
interval: "month" | "year";
sponsoredSubscriptionItem: boolean;
constructor(response: any) {

8
libs/common/src/services/i18n.service.ts → libs/common/src/services/i18n.service.implementation.ts
View File

@@ -1,8 +1,8 @@
import { Observable, ReplaySubject } from "rxjs";
import { I18nService as I18nServiceAbstraction } from "../abstractions/i18n.service";
import { I18nService } from "../abstractions/i18n.service";
export class I18nService implements I18nServiceAbstraction {
export class I18nServiceImplementation<TKey = string> implements I18nService<TKey> {
private _locale = new ReplaySubject<string>(1);
locale$: Observable<string> = this._locale.asObservable();
// First locale is the default (English)
@@ -118,11 +118,11 @@ export class I18nService implements I18nServiceAbstraction {
}
}
t(id: string, p1?: string, p2?: string, p3?: string): string {
t(id: TKey, p1?: string, p2?: string, p3?: string): string {
return this.translate(id, p1, p2, p3);
}
translate(id: string, p1?: string | number, p2?: string | number, p3?: string | number): string {
translate(id: TKey, p1?: string | number, p2?: string | number, p3?: string | number): string {
let result: string;
// eslint-disable-next-line
if (this.localeMessages.hasOwnProperty(id) && this.localeMessages[id]) {