bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-15 07:43:35 +00:00
Code Issues Releases Wiki Activity

[PM-9111] Extension: persist add/edit form (#12236)

Browse Source 
* remove todo

* Retrieve cache cipher for add-edit form

* user prefilled cipher for add-edit form

* add listener for clearing view cache

* clear local cache when clearing global state

* track initial value of cache for down stream logic that should only occur on non-cached values

* add feature flag for edit form persistence

* add tests for cipher form cache service

* fix optional initialValues

* add services to cipher form storybook

* fix strict types

* rename variables to be platform agnostic

* use deconstructed collectionIds variable to avoid them be overwritten

* use the originalCipherView for initial values

* add comment about signal equality

* prevent events from being emitted when adding uris to the existing form

- This stops other values from being overwrote in the initialization process

* add check for cached cipher when adding initial uris
This commit is contained in:
Nick Krantz
2025-01-22 10:49:07 -06:00
committed by GitHub
parent 1dfae06856
commit 5c32e5020d
22 changed files with 460 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
libs/vault/src/cipher-form/components/item-details/item-details-section.component.ts
View File

@@ -183,8 +183,10 @@ export class ItemDetailsSectionComponent implements OnInit {
throw new Error("No organizations available for ownership.");
}
if (this.originalCipherView) {
await this.initFromExistingCipher();
const prefillCipher = this.cipherFormContainer.getInitialCipherView();
if (prefillCipher) {
await this.initFromExistingCipher(prefillCipher);
} else {
this.itemDetailsForm.setValue({
name: this.initialValues?.name || "",
@@ -210,30 +212,37 @@ export class ItemDetailsSectionComponent implements OnInit {
.subscribe();
}
private async initFromExistingCipher() {
private async initFromExistingCipher(prefillCipher: CipherView) {
const { name, folderId, collectionIds } = prefillCipher;
this.itemDetailsForm.setValue({
name: this.initialValues?.name ?? this.originalCipherView.name,
organizationId: this.originalCipherView.organizationId, // We do not allow changing ownership of an existing cipher.
folderId: this.initialValues?.folderId ?? this.originalCipherView.folderId,
name: name ? name : (this.initialValues?.name ?? ""),
organizationId: prefillCipher.organizationId, // We do not allow changing ownership of an existing cipher.
folderId: folderId ? folderId : (this.initialValues?.folderId ?? null),
collectionIds: [],
favorite: this.originalCipherView.favorite,
favorite: prefillCipher.favorite,
});
const initializedWithCachedCipher = this.cipherFormContainer.initializedWithCachedCipher();
// Configure form for clone mode.
if (this.config.mode === "clone") {
this.itemDetailsForm.controls.name.setValue(
this.originalCipherView.name + " - " + this.i18nService.t("clone"),
);
if (!initializedWithCachedCipher) {
this.itemDetailsForm.controls.name.setValue(
prefillCipher.name + " - " + this.i18nService.t("clone"),
);
}
if (!this.allowPersonalOwnership && this.originalCipherView.organizationId == null) {
if (!this.allowPersonalOwnership && prefillCipher.organizationId == null) {
this.itemDetailsForm.controls.organizationId.setValue(this.defaultOwner);
}
}
await this.updateCollectionOptions(
this.initialValues?.collectionIds ??
(this.originalCipherView.collectionIds as CollectionId[]),
);
const prefillCollections = collectionIds?.length
? (collectionIds as CollectionId[])
: (this.initialValues?.collectionIds ?? []);
await this.updateCollectionOptions(prefillCollections);
if (this.partialEdit) {
this.itemDetailsForm.disable();