bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 08:43:33 +00:00
Code Issues Releases Wiki Activity

apply code review

Browse Source
This commit is contained in:
William Martin
2023-09-01 11:16:09 -04:00
parent 3bdb52c613
commit 5c99e278b6
4 changed files with 9 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
apps/browser/src/popup/components/desktop-sync-verification-dialog.component.ts
View File

@@ -2,12 +2,7 @@ import { DIALOG_DATA } from "@angular/cdk/dialog";
import { Component, Inject } from "@angular/core"; import { Component, Inject } from "@angular/core";
import { JslibModule } from "@bitwarden/angular/jslib.module"; import { JslibModule } from "@bitwarden/angular/jslib.module";
import { import { ButtonModule, DialogModule, DialogService } from "@bitwarden/components";
AsyncActionsModule,
ButtonModule,
DialogModule,
DialogService,
} from "@bitwarden/components";
export type DesktopSyncVerificationDialogParams = { export type DesktopSyncVerificationDialogParams = {
fingerprint: string; fingerprint: string;
@@ -16,7 +11,7 @@ export type DesktopSyncVerificationDialogParams = {
@Component({ @Component({
templateUrl: "desktop-sync-verification-dialog.component.html", templateUrl: "desktop-sync-verification-dialog.component.html",
standalone: true, standalone: true,
imports: [JslibModule, ButtonModule, DialogModule, AsyncActionsModule], imports: [JslibModule, ButtonModule, DialogModule],
}) })
export class DesktopSyncVerificationDialogComponent { export class DesktopSyncVerificationDialogComponent {
constructor(@Inject(DIALOG_DATA) protected params: DesktopSyncVerificationDialogParams) {} constructor(@Inject(DIALOG_DATA) protected params: DesktopSyncVerificationDialogParams) {}

2
apps/browser/src/popup/settings/await-desktop-dialog.component.html
View File

@@ -1,5 +1,5 @@
<bit-simple-dialog> <bit-simple-dialog>
<span bitDialogTitle> {{ "awaitDesktop" | i18n }}: </span> <span bitDialogTitle>{{ "awaitDesktop" | i18n }}</span>
<span bitDialogContent> <span bitDialogContent>
{{ "awaitDesktopDesc" | i18n }} {{ "awaitDesktopDesc" | i18n }}
</span> </span>

9
apps/browser/src/popup/settings/await-desktop-dialog.component.ts
View File

@@ -1,17 +1,12 @@
import { Component } from "@angular/core"; import { Component } from "@angular/core";
import { JslibModule } from "@bitwarden/angular/jslib.module"; import { JslibModule } from "@bitwarden/angular/jslib.module";
import { import { ButtonModule, DialogModule, DialogService } from "@bitwarden/components";
AsyncActionsModule,
ButtonModule,
DialogModule,
DialogService,
} from "@bitwarden/components";
@Component({ @Component({
templateUrl: "await-desktop-dialog.component.html", templateUrl: "await-desktop-dialog.component.html",
standalone: true, standalone: true,
imports: [JslibModule, ButtonModule, DialogModule, AsyncActionsModule], imports: [JslibModule, ButtonModule, DialogModule],
}) })
export class AwaitDesktopDialogComponent { export class AwaitDesktopDialogComponent {
static open(dialogService: DialogService) { static open(dialogService: DialogService) {

7
apps/desktop/src/app/components/browser-sync-verification-dialog.component.html
View File

@@ -3,9 +3,10 @@
{{ "verifyBrowserTitle" | i18n }} {{ "verifyBrowserTitle" | i18n }}
</span> </span>
<span bitDialogContent> <span bitDialogContent>
{{ "verifyBrowserDesc" | i18n }} <p>{{ "verifyBrowserDesc" | i18n }}</p>
<br /><br /> <p>
<strong>{{ params.fingerprint }}</strong> <strong>{{ params.fingerprint }}</strong>
</p>
</span> </span>
<ng-container bitDialogFooter> <ng-container bitDialogFooter>
<button bitButton type="submit" buttonType="primary" [bitDialogClose]="true"> <button bitButton type="submit" buttonType="primary" [bitDialogClose]="true">