[SM-478] Resolve introduced eslint errors for button type (#4612)

libs/components/src/banner/banner.component.html

@@ -1,5 +1,3 @@
-<!-- Please remove this disable statement when editing this file! -->
-<!-- eslint-disable @angular-eslint/template/button-has-type -->
 <div
   class="tw-flex tw-items-center tw-gap-2 tw-p-2 tw-pl-4 tw-text-contrast"
   [ngClass]="bannerClass"
@@ -11,6 +9,7 @@
     <ng-content></ng-content>
   </span>
   <button
+    type="button"
     bitIconButton="bwi-close"
     buttonType="contrast"
     size="default"

libs/components/src/breadcrumbs/breadcrumbs.component.html

@@ -1,5 +1,3 @@
-<!-- Please remove this disable statement when editing this file! -->
-<!-- eslint-disable @angular-eslint/template/button-has-type -->
 <ng-container *ngFor="let breadcrumb of beforeOverflow; let last = last">
   <ng-container *ngIf="breadcrumb.route">
     <a
@@ -14,6 +12,7 @@
   </ng-container>
   <ng-container *ngIf="!breadcrumb.route">
     <button
+      type="button"
       bitLink
       linkType="primary"
       class="tw-my-2 tw-inline-block"
@@ -29,6 +28,7 @@
   <i *ngIf="beforeOverflow.length > 0" class="bwi bwi-angle-right tw-mx-1.5 tw-text-main"></i>
 
   <button
+    type="button"
     bitIconButton="bwi-ellipsis-h"
     [bitMenuTriggerFor]="overflowMenu"
     size="small"
@@ -48,7 +48,7 @@
         </a>
       </ng-container>
       <ng-container *ngIf="!breadcrumb.route">
-        <button bitMenuItem linkType="primary" (click)="breadcrumb.onClick($event)">
+        <button type="button" bitMenuItem linkType="primary" (click)="breadcrumb.onClick($event)">
           <ng-container [ngTemplateOutlet]="breadcrumb.content"></ng-container>
         </button>
       </ng-container>
@@ -70,6 +70,7 @@
     </ng-container>
     <ng-container *ngIf="!breadcrumb.route">
       <button
+        type="button"
         bitLink
         linkType="primary"
         class="tw-my-2 tw-inline-block"

libs/components/src/dialog/simple-configurable-dialog/simple-configurable-dialog.component.html

@@ -1,5 +1,3 @@
-<!-- Please remove this disable statement when editing this file! -->
-<!-- eslint-disable @angular-eslint/template/button-has-type -->
 <bit-simple-dialog>
   <i bit-dialog-icon class="bwi tw-text-3xl" [class]="iconClasses" aria-hidden="true"></i>
 
@@ -8,12 +6,18 @@
   <div bitDialogContent>{{ content }}</div>
 
   <div bitDialogFooter class="tw-flex tw-flex-row tw-gap-2">
-    <button bitButton buttonType="primary" (click)="dialogRef.close(SimpleDialogCloseType.ACCEPT)">
+    <button
+      type="button"
+      bitButton
+      buttonType="primary"
+      (click)="dialogRef.close(SimpleDialogCloseType.ACCEPT)"
+    >
       {{ acceptButtonText }}
     </button>
 
     <button
       *ngIf="showCancelButton"
+      type="button"
       bitButton
       buttonType="secondary"
       (click)="dialogRef.close(SimpleDialogCloseType.CANCEL)"

libs/components/src/navigation/nav-group.component.html

@@ -1,5 +1,3 @@
-<!-- Please remove this disable statement when editing this file! -->
-<!-- eslint-disable @angular-eslint/template/button-has-type -->
 <!-- This a higher order component that composes `NavItemComponent`  -->
 <bit-nav-item
   [text]="text"
@@ -13,6 +11,7 @@
 >
   <ng-template #button>
     <button
+      type="button"
       class="tw-ml-auto"
       [bitIconButton]="
         open ? 'bwi-angle-up' : variant === 'tree' ? 'bwi-angle-right' : 'bwi-angle-down'

libs/components/src/navigation/nav-item.component.html

@@ -1,5 +1,3 @@
-<!-- Please remove this disable statement when editing this file! -->
-<!-- eslint-disable @angular-eslint/template/button-has-type -->
 <div
   class="tw-relative"
   [ngClass]="[
@@ -28,6 +26,7 @@
       }"
     >
       <button
+        type="button"
         class="tw-invisible"
         [bitIconButton]="'bwi-angle-down'"
         size="small"
@@ -65,6 +64,7 @@
     <ng-template #isButton>
       <!-- Class field should match `#isAnchor` class field above -->
       <button
+        type="button"
         class="fvw tw-w-full tw-overflow-hidden tw-text-ellipsis tw-whitespace-nowrap tw-border-none tw-bg-transparent tw-p-0 tw-text-start !tw-text-alt2 hover:tw-text-alt2 hover:tw-no-underline focus:tw-outline-none [&>:not(.bwi)]:hover:tw-underline"
         (click)="mainContentClicked.emit()"
       >