bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-03-01 11:01:17 +00:00
Code Issues Releases Wiki Activity

[CL-82] rename bit-icon to bit-svg; create new bit-icon component for font icons (#18584)

Browse Source 
* rename bit-icon to bit-svg; create new bit-icon for font icons

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* find and replace current usage

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* add custom eslint warning

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix incorrect usage

* fix tests

* fix tests

* Update libs/components/src/svg/index.ts

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

* Update libs/eslint/components/no-bwi-class-usage.spec.mjs

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

* update component api

* update class name

* use icon type in iconButton component

* update type Icon --> BitSvg

* fix bad renames

* fix more renames

* fix bad input

* revert iconButton type

* fix lint

* fix more inputs

* misc fixes

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix test

* add eslint ignore

* fix lint

* add comparison story

---------

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
This commit is contained in:
Will Martin
2026-01-28 11:36:27 -05:00
committed by GitHub
parent 61225e6015
commit 5dc49f21d2
161 changed files with 764 additions and 529 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libs/components/src/navigation/nav-logo.component.html
View File

@@ -16,6 +16,6 @@
routerLinkActive
ariaCurrentWhenActive="page"
>
<bit-icon [icon]="sideNavService.open() ? openIcon() : closedIcon()"></bit-icon>
<bit-svg [content]="sideNavService.open() ? openIcon() : closedIcon()"></bit-svg>
</a>
</div>

8
libs/components/src/navigation/nav-logo.component.ts
View File

@@ -1,16 +1,16 @@
import { ChangeDetectionStrategy, Component, input, inject } from "@angular/core";
import { RouterLinkActive, RouterLink } from "@angular/router";
import { BitwardenShield, Icon } from "@bitwarden/assets/svg";
import { BitwardenShield, BitSvg } from "@bitwarden/assets/svg";
import { BitIconComponent } from "../icon/icon.component";
import { SvgComponent } from "../svg/svg.component";
import { SideNavService } from "./side-nav.service";
@Component({
selector: "bit-nav-logo",
templateUrl: "./nav-logo.component.html",
imports: [RouterLinkActive, RouterLink, BitIconComponent],
imports: [RouterLinkActive, RouterLink, SvgComponent],
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class NavLogoComponent {
@@ -26,7 +26,7 @@ export class NavLogoComponent {
/**
* Icon that is displayed when the side nav is open
*/
readonly openIcon = input.required<Icon>();
readonly openIcon = input.required<BitSvg>();
/**
* Route to be passed to internal `routerLink`