[PM-4882] Passkeys: funnel rp name or id to the cipher name on save (#7969)

* funnel rp name or id to the cipher name on save

* remove comment

* add rp name and id to addCipher function

---------

Co-authored-by: Merissa Weinstein <merissaweinstein@merissas-mbp-2.lan>

libs/common/src/vault/abstractions/fido2/fido2-user-interface.service.abstraction.ts

@@ -16,6 +16,10 @@ export interface NewCredentialParams {
    * Whether or not the user must be verified before completing the operation.
    */
   userVerification: boolean;
+  /**
+   * The relying party ID is usually the URL
+   */
+  rpId: string;
 }
 
 /**

libs/common/src/vault/services/fido2/fido2-authenticator.service.spec.ts

@@ -216,6 +216,7 @@ describe("FidoAuthenticatorService", () => {
             credentialName: params.rpEntity.name,
             userName: params.userEntity.displayName,
             userVerification,
+            rpId: params.rpEntity.id,
           } as NewCredentialParams);
         });
       }

libs/common/src/vault/services/fido2/fido2-authenticator.service.ts

@@ -113,6 +113,7 @@ export class Fido2AuthenticatorService implements Fido2AuthenticatorServiceAbstr
         credentialName: params.rpEntity.name,
         userName: params.userEntity.displayName,
         userVerification: params.requireUserVerification,
+        rpId: params.rpEntity.id,
       });
       const cipherId = response.cipherId;
       userVerified = response.userVerified;