1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-13 06:43:35 +00:00

[PM-4358] Passkey can be Created but not Retrieved on eBay (#6617)

* changed behaviour to require user verification when preferred use preferred when user verification is not defined

* changed behaviour to require user verification when preferred use preferred when user verification is not defined
This commit is contained in:
SmithThe4th
2023-10-18 16:25:24 -04:00
committed by GitHub
parent 21b1f87724
commit 5dd2e3a1e3

View File

@@ -363,9 +363,14 @@ function mapToMakeCredentialParams({
(params.authenticatorSelection?.residentKey === undefined && (params.authenticatorSelection?.residentKey === undefined &&
params.authenticatorSelection?.requireResidentKey === true); params.authenticatorSelection?.requireResidentKey === true);
const requireUserVerification =
params.authenticatorSelection?.userVerification === "required" ||
params.authenticatorSelection?.userVerification === "preferred" ||
params.authenticatorSelection?.userVerification === undefined;
return { return {
requireResidentKey, requireResidentKey,
requireUserVerification: params.authenticatorSelection?.userVerification === "required", requireUserVerification,
enterpriseAttestationPossible: params.attestation === "enterprise", enterpriseAttestationPossible: params.attestation === "enterprise",
excludeCredentialDescriptorList, excludeCredentialDescriptorList,
credTypesAndPubKeyAlgs, credTypesAndPubKeyAlgs,
@@ -398,9 +403,14 @@ function mapToGetAssertionParams({
type: "public-key", type: "public-key",
})); }));
const requireUserVerification =
params.userVerification === "required" ||
params.userVerification === "preferred" ||
params.userVerification === undefined;
return { return {
rpId: params.rpId, rpId: params.rpId,
requireUserVerification: params.userVerification === "required", requireUserVerification,
hash: clientDataHash, hash: clientDataHash,
allowCredentialDescriptorList, allowCredentialDescriptorList,
extensions: {}, extensions: {},