PM-5022 Migrate Payment Method component (#8397)

* PM-5022 Migrated Payment Method component

* PM-5022 Addressed review comments

* PM-5022 Addressed review comments on CSS

* PM-5022 Addressed the css comment and fixed build issues

* PM-5022 Changed app-callout to bit-callout

---------

Co-authored-by: cyprain-okeke <108260115+cyprain-okeke@users.noreply.github.com>

apps/web/src/app/billing/shared/payment-method.component.html

@@ -3,7 +3,7 @@
     type="button"
     bitButton
     buttonType="secondary"
-    (click)="load()"
+    [bitAction]="load"
     class="tw-ml-auto"
     *ngIf="firstLoaded"
     [disabled]="loading"
@@ -14,32 +14,33 @@
 </app-header>
 
 <bit-container>
-  <div class="tabbed-header" *ngIf="!organizationId">
   <!-- TODO: Organization and individual should use different "page" components -->
-    <h1>{{ "paymentMethod" | i18n }}</h1>
+  <h2 bitTypography="h1" *ngIf="!organizationId">{{ "paymentMethod" | i18n }}</h2>
-  </div>
 
   <ng-container *ngIf="!firstLoaded && loading">
     <i
-      class="bwi bwi-spinner bwi-spin text-muted"
+      class="bwi bwi-spinner bwi-spin tw-text-muted"
       title="{{ 'loading' | i18n }}"
       aria-hidden="true"
     ></i>
-    <span class="sr-only">{{ "loading" | i18n }}</span>
+    <span class="tw-sr-only">{{ "loading" | i18n }}</span>
   </ng-container>
   <ng-container *ngIf="billing">
-    <h2>{{ (isCreditBalance ? "accountCredit" : "accountBalance") | i18n }}</h2>
+    <bit-section>
-    <p class="text-lg">
+      <h2 bitTypography="h2">
-      <strong>{{ creditOrBalance | currency: "$" }}</strong>
+        {{ (isCreditBalance ? "accountCredit" : "accountBalance") | i18n }}
-    </p>
+      </h2>
-    <p>{{ "creditAppliedDesc" | i18n }}</p>
+      <p class="tw-text-lg tw-font-bold">{{ creditOrBalance | currency: "$" }}</p>
+      <p bitTypography="body1">{{ "creditAppliedDesc" | i18n }}</p>
       <button type="button" bitButton buttonType="secondary" [bitAction]="addCredit">
         {{ "addCredit" | i18n }}
       </button>
-    <h2 class="spaced-header">{{ "paymentMethod" | i18n }}</h2>
+    </bit-section>
-    <p *ngIf="!paymentSource">{{ "noPaymentMethod" | i18n }}</p>
+    <bit-section>
+      <h2 bitTypography="h2">{{ "paymentMethod" | i18n }}</h2>
+      <p *ngIf="!paymentSource" bitTypography="body1">{{ "noPaymentMethod" | i18n }}</p>
       <ng-container *ngIf="paymentSource">
-      <app-callout
+        <bit-callout
           type="warning"
           title="{{ 'verifyBankAccount' | i18n }}"
           *ngIf="
@@ -48,42 +49,29 @@
             paymentSource.needsVerification
           "
         >
-        <p>{{ "verifyBankAccountDesc" | i18n }} {{ "verifyBankAccountFailureWarning" | i18n }}</p>
+          <p bitTypography="body1">
+            {{ "verifyBankAccountDesc" | i18n }} {{ "verifyBankAccountFailureWarning" | i18n }}
+          </p>
           <form
-          #verifyForm
-          class="form-inline"
-          (ngSubmit)="verifyBank()"
             [formGroup]="verifyBankForm"
-          [appApiAction]="verifyBankPromise"
+            [bitSubmit]="verifyBank"
-          ngNativeValidate
+            class="tw-flex tw-flex-wrap tw-items-center tw-space-x-2"
           >
-          <bit-form-field class="tw-mr-2 tw-w-40">
+            <bit-form-field class="tw-w-40">
               <bit-label>{{ "amountX" | i18n: "1" }}</bit-label>
               <input bitInput type="number" step="1" placeholder="xx" formControlName="amount1" />
               <span bitPrefix>$0.</span>
             </bit-form-field>
-          <bit-form-field class="tw-mr-2 tw-w-40">
+            <bit-form-field class="tw-w-40">
               <bit-label>{{ "amountX" | i18n: "2" }}</bit-label>
               <input bitInput type="number" step="1" placeholder="xx" formControlName="amount2" />
               <span bitPrefix>$0.</span>
             </bit-form-field>
-          <button
+            <button bitButton bitFormButton buttonType="primary" type="submit">
-            type="button"
+              {{ "verifyBankAccount" | i18n }}
-            bitButton
-            buttonType="primary"
-            type="submit"
-            class="btn-submit"
-            [disabled]="verifyForm.loading"
-          >
-            <i
-              class="bwi bwi-spinner bwi-spin"
-              title="{{ 'loading' | i18n }}"
-              aria-hidden="true"
-            ></i>
-            <span>{{ "verifyBankAccount" | i18n }}</span>
             </button>
           </form>
-      </app-callout>
+        </bit-callout>
         <p>
           <i class="bwi bwi-fw" [ngClass]="paymentSourceClasses"></i>
           {{ paymentSource.description }}
@@ -92,37 +80,27 @@
       <button type="button" bitButton buttonType="secondary" [bitAction]="changePayment">
         {{ (paymentSource ? "changePaymentMethod" : "addPaymentMethod") | i18n }}
       </button>
-    <p *ngIf="isUnpaid">{{ "paymentChargedWithUnpaidSubscription" | i18n }}</p>
+      <p *ngIf="isUnpaid" bitTypography="body1">
-    <ng-container *ngIf="forOrganization">
+        {{ "paymentChargedWithUnpaidSubscription" | i18n }}
-      <h2 class="spaced-header">{{ "taxInformation" | i18n }}</h2>
+      </p>
-      <p>{{ "taxInformationDesc" | i18n }}</p>
+    </bit-section>
+    <bit-section *ngIf="forOrganization">
+      <h2 bitTypography="h2">{{ "taxInformation" | i18n }}</h2>
+      <p bitTypography="body1">{{ "taxInformationDesc" | i18n }}</p>
       <div *ngIf="!org || loading">
         <i
-          class="bwi bwi-spinner bwi-spin text-muted"
+          class="bwi bwi-spinner bwi-spin tw-text-muted"
           title="{{ 'loading' | i18n }}"
           aria-hidden="true"
         ></i>
-        <span class="sr-only">{{ "loading" | i18n }}</span>
+        <span class="tw-sr-only">{{ "loading" | i18n }}</span>
       </div>
-      <form
+      <form *ngIf="org && !loading" [formGroup]="taxForm" [bitSubmit]="submitTaxInfo">
-        *ngIf="org && !loading"
-        #formTax
-        (ngSubmit)="submitTaxInfo()"
-        [appApiAction]="taxFormPromise"
-        ngNativeValidate
-      >
         <app-tax-info></app-tax-info>
-        <button
+        <button bitButton bitFormButton buttonType="primary" type="submit">
-          bitButton
+          {{ "save" | i18n }}
-          buttonType="primary"
-          type="submit"
-          class="btn-submit"
-          [disabled]="formTax.loading"
-        >
-          <i class="bwi bwi-spinner bwi-spin" title="{{ 'loading' | i18n }}" aria-hidden="true"></i>
-          <span>{{ "save" | i18n }}</span>
         </button>
       </form>
-    </ng-container>
+    </bit-section>
   </ng-container>
 </bit-container>

apps/web/src/app/billing/shared/payment-method.component.ts

@@ -38,9 +38,6 @@ export class PaymentMethodComponent implements OnInit {
   organizationId: string;
   isUnpaid = false;
 
-  verifyBankPromise: Promise<any>;
-  taxFormPromise: Promise<any>;
-
   verifyBankForm = this.formBuilder.group({
     amount1: new FormControl<number>(null, [
       Validators.required,
@@ -54,6 +51,8 @@ export class PaymentMethodComponent implements OnInit {
     ]),
   });
 
+  taxForm = this.formBuilder.group({});
+
   constructor(
     protected apiService: ApiService,
     protected organizationApiService: OrganizationApiServiceAbstraction,
@@ -83,7 +82,7 @@ export class PaymentMethodComponent implements OnInit {
     });
   }
 
-  async load() {
+  load = async () => {
     if (this.loading) {
       return;
     }
@@ -109,7 +108,7 @@ export class PaymentMethodComponent implements OnInit {
     this.isUnpaid = this.subscription?.status === "unpaid" ?? false;
 
     this.loading = false;
-  }
+  };
 
   addCredit = async () => {
     const dialogRef = openAddCreditDialog(this.dialogService, {
@@ -136,35 +135,23 @@ export class PaymentMethodComponent implements OnInit {
     }
   };
 
-  async verifyBank() {
+  verifyBank = async () => {
     if (this.loading || !this.forOrganization) {
       return;
     }
 
-    try {
     const request = new VerifyBankRequest();
     request.amount1 = this.verifyBankForm.value.amount1;
     request.amount2 = this.verifyBankForm.value.amount2;
-      this.verifyBankPromise = this.organizationApiService.verifyBank(this.organizationId, request);
+    await this.organizationApiService.verifyBank(this.organizationId, request);
-      await this.verifyBankPromise;
+    this.platformUtilsService.showToast("success", null, this.i18nService.t("verifiedBankAccount"));
-      this.platformUtilsService.showToast(
+    await this.load();
-        "success",
+  };
-        null,
-        this.i18nService.t("verifiedBankAccount"),
-      );
-      // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
-      // eslint-disable-next-line @typescript-eslint/no-floating-promises
-      this.load();
-    } catch (e) {
-      this.logService.error(e);
-    }
-  }
 
-  async submitTaxInfo() {
+  submitTaxInfo = async () => {
-    this.taxFormPromise = this.taxInfo.submitTaxInfo();
+    await this.taxInfo.submitTaxInfo();
-    await this.taxFormPromise;
     this.platformUtilsService.showToast("success", null, this.i18nService.t("taxInfoUpdated"));
-  }
+  };
 
   get isCreditBalance() {
     return this.billing == null || this.billing.balance <= 0;