chore(flag-removal): [Auth/PM20439] Remove flagging logic and flag (BrowserExtensionLoginApproval) (#16568)

libs/common/src/enums/feature-flag.enum.ts

@@ -15,7 +15,6 @@ export enum FeatureFlag {
   CollectionVaultRefactor = "pm-25030-resolve-ts-upgrade-errors",
 
   /* Auth */
-  PM14938_BrowserExtensionLoginApproval = "pm-14938-browser-extension-login-approvals",
   PM22110_DisableAlternateLoginMethods = "pm-22110-disable-alternate-login-methods",
 
   /* Autofill */
@@ -98,7 +97,6 @@ export const DefaultFeatureFlagValue = {
   [FeatureFlag.PM22136_SdkCipherEncryption]: FALSE,
 
   /* Auth */
-  [FeatureFlag.PM14938_BrowserExtensionLoginApproval]: FALSE,
   [FeatureFlag.PM22110_DisableAlternateLoginMethods]: FALSE,
 
   /* Billing */

libs/common/src/platform/server-notifications/internal/default-server-notifications.multiuser.spec.ts

@@ -132,7 +132,6 @@ describe("DefaultServerNotificationsService (multi-user)", () => {
       const flagValueByFlag: Partial<Record<FeatureFlag, boolean>> = {
         [FeatureFlag.InactiveUserServerNotification]: true,
         [FeatureFlag.PushNotificationsWhenLocked]: true,
-        [FeatureFlag.PM14938_BrowserExtensionLoginApproval]: true,
       };
       return new BehaviorSubject(flagValueByFlag[flag] ?? false) as any;
     });

libs/common/src/platform/server-notifications/internal/default-server-notifications.service.ts

@@ -278,16 +278,21 @@ export class DefaultServerNotificationsService implements ServerNotificationsSer
         await this.syncService.syncDeleteSend(notification.payload as SyncSendNotification);
         break;
       case NotificationType.AuthRequest:
-        if (
-          await firstValueFrom(
-            this.configService.getFeatureFlag$(FeatureFlag.PM14938_BrowserExtensionLoginApproval),
-          )
-        ) {
-          await this.authRequestAnsweringService.receivedPendingAuthRequest(
-            notification.payload.userId,
-            notification.payload.id,
-          );
-        }
+        await this.authRequestAnsweringService.receivedPendingAuthRequest(
+          notification.payload.userId,
+          notification.payload.id,
+        );
+
+        /**
+         * This call is necessary for Desktop, which for the time being uses a noop for the
+         * authRequestAnsweringService.receivedPendingAuthRequest() call just above. Desktop
+         * will eventually use the new AuthRequestAnsweringService, at which point we can remove
+         * this second call.
+         *
+         * The Extension AppComponent has logic (see processingPendingAuth) that only allows one
+         * pending auth request to process at a time, so this second call will not cause any
+         * duplicate processing conflicts on Extension.
+         */
         this.messagingService.send("openLoginApproval", {
           notificationId: notification.payload.id,
         });