Add eslint (#610)

electron/package.json

@@ -15,9 +15,7 @@
   "scripts": {
     "clean": "rimraf dist/**/*",
     "build": "npm run clean && tsc",
-    "build:watch": "npm run clean && tsc -watch",
-    "lint": "tslint 'src/**/*.ts' 'spec/**/*.ts'",
-    "lint:fix": "tslint 'src/**/*.ts' 'spec/**/*.ts' --fix"
+    "build:watch": "npm run clean && tsc -watch"
   },
   "devDependencies": {
     "@types/node": "^16.11.12",

electron/src/baseMenu.ts

@@ -1,6 +1,7 @@
-import { app, clipboard, dialog, Menu, MenuItemConstructorOptions } from "electron";
+import { Menu, MenuItemConstructorOptions } from "electron";
 
 import { I18nService } from "jslib-common/abstractions/i18n.service";
+
 import { WindowMain } from "./window.main";
 
 export class BaseMenu {

electron/src/biometric.darwin.main.ts

@@ -5,7 +5,7 @@ import { I18nService } from "jslib-common/abstractions/i18n.service";
 import { StateService } from "jslib-common/abstractions/state.service";
 
 export default class BiometricDarwinMain implements BiometricMain {
-  isError: boolean = false;
+  isError = false;
 
   constructor(private i18nservice: I18nService, private stateService: StateService) {}
 
@@ -14,6 +14,7 @@ export default class BiometricDarwinMain implements BiometricMain {
     await this.stateService.setBiometricText("unlockWithTouchId");
     await this.stateService.setNoAutoPromptBiometricsText("noAutoPromptTouchId");
 
+    // eslint-disable-next-line
     ipcMain.on("biometric", async (event: any, message: any) => {
       event.returnValue = await this.authenticateBiometric();
     });

electron/src/biometric.windows.main.ts

@@ -1,15 +1,15 @@
 import { ipcMain } from "electron";
 import forceFocus from "forcefocus";
 
-import { WindowMain } from "./window.main";
-
 import { BiometricMain } from "jslib-common/abstractions/biometric.main";
 import { I18nService } from "jslib-common/abstractions/i18n.service";
 import { LogService } from "jslib-common/abstractions/log.service";
 import { StateService } from "jslib-common/abstractions/state.service";
 
+import { WindowMain } from "./window.main";
+
 export default class BiometricWindowsMain implements BiometricMain {
-  isError: boolean = false;
+  isError = false;
 
   private windowsSecurityCredentialsUiModule: any;
 
@@ -72,6 +72,7 @@ export default class BiometricWindowsMain implements BiometricMain {
   async checkAvailabilityAsync(): Promise<any> {
     const module = this.getWindowsSecurityCredentialsUiModule();
     if (module != null) {
+      // eslint-disable-next-line
       return new Promise((resolve, reject) => {
         try {
           module.UserConsentVerifier.checkAvailabilityAsync((error: Error, result: any) => {
@@ -134,6 +135,7 @@ export default class BiometricWindowsMain implements BiometricMain {
       return -1;
     }
     try {
+      // eslint-disable-next-line
       const version = require("os").release();
       return Number.parseInt(version.split(".")[0], 10);
     } catch {

electron/src/keytarStorageListener.ts

@@ -1,5 +1,4 @@
 import { ipcMain } from "electron";
-
 import { deletePassword, getPassword, setPassword } from "keytar";
 
 import { BiometricMain } from "jslib-common/abstractions/biometric.main";

electron/src/services/electronCrypto.service.ts

@@ -2,12 +2,9 @@ import { CryptoFunctionService } from "jslib-common/abstractions/cryptoFunction.
 import { LogService } from "jslib-common/abstractions/log.service";
 import { PlatformUtilsService } from "jslib-common/abstractions/platformUtils.service";
 import { StateService } from "jslib-common/abstractions/state.service";
-
-import { CryptoService } from "jslib-common/services/crypto.service";
-
 import { KeySuffixOptions } from "jslib-common/enums/keySuffixOptions";
-import { StorageLocation } from "jslib-common/enums/storageLocation";
 import { SymmetricCryptoKey } from "jslib-common/models/domain/symmetricCryptoKey";
+import { CryptoService } from "jslib-common/services/crypto.service";
 
 export class ElectronCryptoService extends CryptoService {
   constructor(

electron/src/services/electronLog.service.ts

@@ -1,12 +1,12 @@
-import log from "electron-log";
 import * as path from "path";
 
-import { isDev } from "../utils";
+import log from "electron-log";
 
 import { LogLevelType } from "jslib-common/enums/logLevelType";
-
 import { ConsoleLogService as BaseLogService } from "jslib-common/services/consoleLog.service";
 
+import { isDev } from "../utils";
+
 export class ElectronLogService extends BaseLogService {
   constructor(protected filter: (level: LogLevelType) => boolean = null, logDir: string = null) {
     super(isDev(), filter);

electron/src/services/electronMainMessaging.service.ts

@@ -1,10 +1,9 @@
 import { app, dialog, ipcMain, Menu, MenuItem, nativeTheme } from "electron";
-import { promises as fs } from "fs";
-import { MessagingService } from "jslib-common/abstractions/messaging.service";
-import { RendererMenuItem } from "../utils";
 
+import { MessagingService } from "jslib-common/abstractions/messaging.service";
 import { ThemeType } from "jslib-common/enums/themeType";
 
+import { RendererMenuItem } from "../utils";
 import { WindowMain } from "../window.main";
 
 export class ElectronMainMessagingService implements MessagingService {

electron/src/services/electronPlatformUtils.service.ts

@@ -1,15 +1,14 @@
 import { clipboard, ipcRenderer, shell } from "electron";
 
-import { isDev, isMacAppStore } from "../utils";
-
-import { ClientType } from "jslib-common/enums/clientType";
-import { DeviceType } from "jslib-common/enums/deviceType";
-import { ThemeType } from "jslib-common/enums/themeType";
-
 import { I18nService } from "jslib-common/abstractions/i18n.service";
 import { MessagingService } from "jslib-common/abstractions/messaging.service";
 import { PlatformUtilsService } from "jslib-common/abstractions/platformUtils.service";
 import { StateService } from "jslib-common/abstractions/state.service";
+import { ClientType } from "jslib-common/enums/clientType";
+import { DeviceType } from "jslib-common/enums/deviceType";
+import { ThemeType } from "jslib-common/enums/themeType";
+
+import { isDev, isMacAppStore } from "../utils";
 
 export class ElectronPlatformUtilsService implements PlatformUtilsService {
   private clientType: ClientType;

electron/src/services/electronRendererSecureStorage.service.ts

@@ -1,7 +1,6 @@
 import { ipcRenderer } from "electron";
 
 import { StorageService } from "jslib-common/abstractions/storage.service";
-
 import { StorageOptions } from "jslib-common/models/domain/storageOptions";
 
 export class ElectronRendererSecureStorageService implements StorageService {

electron/src/services/electronStorage.service.ts

@@ -1,11 +1,11 @@
-import { ipcMain, ipcRenderer } from "electron";
 import * as fs from "fs";
 
-import { StorageService } from "jslib-common/abstractions/storage.service";
+import { ipcMain } from "electron";
 
+import { StorageService } from "jslib-common/abstractions/storage.service";
 import { NodeUtils } from "jslib-common/misc/nodeUtils";
 
-// tslint:disable-next-line
+// eslint-disable-next-line
 const Store = require("electron-store");
 
 export class ElectronStorageService implements StorageService {

electron/src/tray.main.ts

@@ -1,6 +1,7 @@
-import { app, BrowserWindow, Menu, MenuItemConstructorOptions, nativeImage, Tray } from "electron";
 import * as path from "path";
 
+import { app, BrowserWindow, Menu, MenuItemConstructorOptions, nativeImage, Tray } from "electron";
+
 import { I18nService } from "jslib-common/abstractions/i18n.service";
 import { StateService } from "jslib-common/abstractions/state.service";
 
@@ -75,7 +76,7 @@ export class TrayMain {
       }
     });
 
-    win.on("show", async (e: Event) => {
+    win.on("show", async () => {
       const enableTray = await this.stateService.getEnableTray();
       if (!enableTray) {
         setTimeout(() => this.removeTray(false), 100);

electron/src/updater.main.ts

@@ -1,10 +1,10 @@
-import { dialog, Menu, MenuItem, shell } from "electron";
+import { dialog, shell } from "electron";
 import log from "electron-log";
 import { autoUpdater } from "electron-updater";
 
-import { isAppImage, isDev, isMacAppStore, isWindowsPortable, isWindowsStore } from "./utils";
-
 import { I18nService } from "jslib-common/abstractions/i18n.service";
+
+import { isAppImage, isDev, isMacAppStore, isWindowsPortable, isWindowsStore } from "./utils";
 import { WindowMain } from "./window.main";
 
 const UpdaterCheckInitalDelay = 5 * 1000; // 5 seconds
@@ -123,7 +123,7 @@ export class UpdaterMain {
     });
   }
 
-  async checkForUpdate(withFeedback: boolean = false) {
+  async checkForUpdate(withFeedback = false) {
     if (this.doingUpdateCheck || isDev()) {
       return;
     }

electron/src/window.main.ts

@@ -1,7 +1,8 @@
-import { app, BrowserWindow, screen } from "electron";
 import * as path from "path";
 import * as url from "url";
 
+import { app, BrowserWindow, screen } from "electron";
+
 import { LogService } from "jslib-common/abstractions/log.service";
 import { StateService } from "jslib-common/abstractions/state.service";
 
@@ -11,11 +12,11 @@ const mainWindowSizeKey = "mainWindowSize";
 const WindowEventHandlingDelay = 100;
 export class WindowMain {
   win: BrowserWindow;
-  isQuitting: boolean = false;
+  isQuitting = false;
 
   private windowStateChangeTimer: NodeJS.Timer;
   private windowStates: { [key: string]: any } = {};
-  private enableAlwaysOnTop: boolean = false;
+  private enableAlwaysOnTop = false;
 
   constructor(
     private stateService: StateService,
@@ -36,6 +37,7 @@ export class WindowMain {
             app.quit();
             return;
           } else {
+            // eslint-disable-next-line
             app.on("second-instance", (event, argv, workingDirectory) => {
               // Someone tried to run a second instance, we should focus our window.
               if (this.win != null) {