bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-19 01:33:33 +00:00
Code Issues Releases Wiki Activity

Clear stale everBeenUnlocked value from onDisk storage (#682)

Browse Source 
* Add StateVersion.Four to remove old everBeenUnlocked key

* Save new state properly

* Add unit tests

* Fix linting
This commit is contained in:
Thomas Rittson
2022-02-14 23:16:07 +10:00
committed by GitHub
parent bcbb52e6ec
commit 609baece05
3 changed files with 110 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
common/src/services/stateMigration.service.ts
View File

@@ -158,6 +158,9 @@ export class StateMigrationService<
case StateVersion.Two:
await this.migrateStateFrom2To3();
break;
case StateVersion.Three:
await this.migrateStateFrom3To4();
break;
}
currentStateVersion += 1;
@@ -474,6 +477,23 @@ export class StateMigrationService<
await this.set(keys.global, globals);
}
protected async migrateStateFrom3To4(): Promise<void> {
const authenticatedUserIds = await this.get<string[]>(keys.authenticatedAccounts);
await Promise.all(
authenticatedUserIds.map(async (userId) => {
const account = await this.get<TAccount>(userId);
if (account?.profile?.everBeenUnlocked != null) {
delete account.profile.everBeenUnlocked;
return this.set(userId, account);
}
})
);
const globals = await this.getGlobals();
globals.stateVersion = StateVersion.Four;
await this.set(keys.global, globals);
}
protected get options(): StorageOptions {
return { htmlStorageLocation: HtmlStorageLocation.Local };
}