1
0
mirror of https://github.com/bitwarden/browser synced 2026-01-04 09:33:27 +00:00

Update workflows with linter suggestions (#2051)

This commit is contained in:
Vince Grassia
2021-09-02 16:03:47 -04:00
committed by GitHub
parent 0bd22dcddc
commit 61f551087f
3 changed files with 68 additions and 59 deletions

View File

@@ -1,3 +1,4 @@
---
name: Build
on:
@@ -10,6 +11,7 @@ on:
jobs:
cloc:
name: CLOC
runs-on: ubuntu-latest
steps:
- name: Checkout repo
@@ -24,6 +26,7 @@ jobs:
setup:
name: Setup
runs-on: ubuntu-latest
outputs:
repo_url: ${{ steps.gen_vars.outputs.repo_url }}
@@ -38,10 +41,11 @@ jobs:
repo_url=https://github.com/$GITHUB_REPOSITORY.git
adj_build_num=${GITHUB_SHA:0:7}
echo "::set-output name=repo_url::$repo_url"
echo "::set-output name=adj_build_number::$adj_build_num"
echo "::set-output name=repo_url::$repo_url"
echo "::set-output name=adj_build_number::$adj_build_num"
locales-test:
name: Locales Test
runs-on: ubuntu-latest
needs: setup
steps:
@@ -63,21 +67,21 @@ jobs:
found_error=true
fi
done
if $found_error; then
echo
echo "Please fix 'extName' for the locales listed above."
exit 1
else
echo "Test passed!"
fi
fi
build:
name: Build
runs-on: windows-latest
needs: [ setup, locales-test ]
needs: [setup, locales-test]
env:
REPO_URL: ${{ needs.setup.outputs.repo_url }}
BUILD_NUMBER: ${{ needs.setup.outputs.adj_build_number }}
_BUILD_NUMBER: ${{ needs.setup.outputs.adj_build_number }}
steps:
- name: Checkout repo
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
@@ -96,41 +100,41 @@ jobs:
node --version
npm --version
- name: npm setup & test
- name: NPM setup & test
run: |
npm install
npm run dist
npm run test
- name: gulp
- name: Gulp
run: gulp ci
- name: Upload opera artifact
- name: Upload Opera artifact
uses: actions/upload-artifact@ee69f02b3dfdecd58bb31b4d133da38ba6fe3700
with:
name: dist-opera-${{ env.BUILD_NUMBER }}.zip
path: dist/dist-opera-${{ env.BUILD_NUMBER }}.zip
name: dist-opera-${{ env._BUILD_NUMBER }}.zip
path: dist/dist-opera-${{ env._BUILD_NUMBER }}.zip
- name: Upload chrome artifact
- name: Upload Chrome artifact
uses: actions/upload-artifact@ee69f02b3dfdecd58bb31b4d133da38ba6fe3700
with:
name: dist-chrome-${{ env.BUILD_NUMBER }}.zip
path: dist/dist-chrome-${{ env.BUILD_NUMBER }}.zip
name: dist-chrome-${{ env._BUILD_NUMBER }}.zip
path: dist/dist-chrome-${{ env._BUILD_NUMBER }}.zip
- name: Upload firefox artifact
- name: Upload Firefox artifact
uses: actions/upload-artifact@ee69f02b3dfdecd58bb31b4d133da38ba6fe3700
with:
name: dist-firefox-${{ env.BUILD_NUMBER }}.zip
path: dist/dist-firefox-${{ env.BUILD_NUMBER }}.zip
name: dist-firefox-${{ env._BUILD_NUMBER }}.zip
path: dist/dist-firefox-${{ env._BUILD_NUMBER }}.zip
- name: Upload edge artifact
- name: Upload Edge artifact
uses: actions/upload-artifact@ee69f02b3dfdecd58bb31b4d133da38ba6fe3700
with:
name: dist-edge-${{ env.BUILD_NUMBER }}.zip
path: dist/dist-edge-${{ env.BUILD_NUMBER }}.zip
name: dist-edge-${{ env._BUILD_NUMBER }}.zip
path: dist/dist-edge-${{ env._BUILD_NUMBER }}.zip
- name: Upload coverage artifact
uses: actions/upload-artifact@ee69f02b3dfdecd58bb31b4d133da38ba6fe3700
with:
name: coverage-${{ env.BUILD_NUMBER }}.zip
path: coverage/coverage-${{ env.BUILD_NUMBER }}.zip
name: coverage-${{ env._BUILD_NUMBER }}.zip
path: coverage/coverage-${{ env._BUILD_NUMBER }}.zip