bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 00:03:56 +00:00
Code Issues Releases Wiki Activity

[PM-5189] Implementing a set threshold for the maximum depth for which we are willing to calculate sub frame offsets

Browse Source
This commit is contained in:
Cesar Gonzalez
2024-06-12 17:40:41 -05:00
parent 6754afb6d6
commit 61fea36604
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/browser/src/autofill/background/overlay.background.ts
View File

@@ -1073,7 +1073,7 @@ export class OverlayBackground implements OverlayBackgroundInterface {
const parentFrameIds = new Set();
subFrameOffsetsForTab.forEach((subFrameOffsetData) =>
subFrameOffsetData.parentFrameIds.forEach((parentFrameId) =>
subFrameOffsetData?.parentFrameIds.forEach((parentFrameId) =>
parentFrameIds.add(parentFrameId),
),
);

2
apps/browser/src/autofill/enums/autofill-overlay.enum.ts
View File

@@ -16,4 +16,4 @@ export const RedirectFocusDirection = {
Next: "next",
} as const;
export const MAX_SUB_FRAME_DEPTH = 10;
export const MAX_SUB_FRAME_DEPTH = 8;

2
apps/browser/src/autofill/services/autofill-overlay-content.service.ts
View File

@@ -1060,7 +1060,7 @@ export class AutofillOverlayContentService implements AutofillOverlayContentServ
const subFrameData: SubFrameDataFromWindowMessage = event.data.subFrameData;
subFrameData.subFrameDepth++;
if (subFrameData.subFrameDepth > MAX_SUB_FRAME_DEPTH) {
if (subFrameData.subFrameDepth >= MAX_SUB_FRAME_DEPTH) {
void this.sendExtensionMessage("destroyAutofillInlineMenuListeners", { subFrameData });
return;
}