bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-19 09:43:23 +00:00
Code Issues Releases Wiki Activity

Adding at risk cipher ids for accurate notifications (#14784)

Browse Source
This commit is contained in:
Tom
2025-05-15 10:36:57 -04:00
committed by GitHub
parent a0429d7d09
commit 623deea4fc
2 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
bitwarden_license/bit-common/src/dirt/reports/risk-insights/models/password-health.ts
View File

@@ -27,6 +27,7 @@ export type ApplicationHealthReportDetail = {
applicationName: string; applicationName: string;
passwordCount: number; passwordCount: number;
atRiskPasswordCount: number; atRiskPasswordCount: number;
atRiskCipherIds: string[];
memberCount: number; memberCount: number;
atRiskMemberCount: number; atRiskMemberCount: number;
memberDetails: MemberDetailsFlat[]; memberDetails: MemberDetailsFlat[];

3
bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/risk-insights-report.service.ts
View File

@@ -354,12 +354,15 @@ export class RiskInsightsReportService {
: newUriDetail.cipherMembers, : newUriDetail.cipherMembers,
atRiskMemberDetails: existingUriDetail ? existingUriDetail.atRiskMemberDetails : [], atRiskMemberDetails: existingUriDetail ? existingUriDetail.atRiskMemberDetails : [],
atRiskPasswordCount: existingUriDetail ? existingUriDetail.atRiskPasswordCount : 0, atRiskPasswordCount: existingUriDetail ? existingUriDetail.atRiskPasswordCount : 0,
atRiskCipherIds: existingUriDetail ? existingUriDetail.atRiskCipherIds : [],
atRiskMemberCount: existingUriDetail ? existingUriDetail.atRiskMemberDetails.length : 0, atRiskMemberCount: existingUriDetail ? existingUriDetail.atRiskMemberDetails.length : 0,
cipher: newUriDetail.cipher, cipher: newUriDetail.cipher,
} as ApplicationHealthReportDetail; } as ApplicationHealthReportDetail;
if (isAtRisk) { if (isAtRisk) {
reportDetail.atRiskPasswordCount = reportDetail.atRiskPasswordCount + 1; reportDetail.atRiskPasswordCount = reportDetail.atRiskPasswordCount + 1;
reportDetail.atRiskCipherIds.push(newUriDetail.cipherId);
reportDetail.atRiskMemberDetails = this.getUniqueMembers( reportDetail.atRiskMemberDetails = this.getUniqueMembers(
reportDetail.atRiskMemberDetails.concat(newUriDetail.cipherMembers), reportDetail.atRiskMemberDetails.concat(newUriDetail.cipherMembers),
); );