From 6392ad82d1d115663ea51006db49261d3aee1c50 Mon Sep 17 00:00:00 2001
From: Andreas Coroiu <andreas.coroiu@gmail.com>
Date: Thu, 5 Jan 2023 17:20:24 +0100
Subject: [PATCH] [EC-598] feat: show all available data

---
 apps/browser/src/_locales/en/messages.json    | 12 +++++++++
 .../src/popup/vault/view.component.html       | 27 +++++++++++++++++++
 libs/common/src/models/api/fido2-key.api.ts   |  1 +
 3 files changed, 40 insertions(+)

diff --git a/apps/browser/src/_locales/en/messages.json b/apps/browser/src/_locales/en/messages.json
index dc151a7e5d0..c6d58234cf4 100644
--- a/apps/browser/src/_locales/en/messages.json
+++ b/apps/browser/src/_locales/en/messages.json
@@ -2046,5 +2046,17 @@
   },
   "rememberEmail": {
     "message": "Remember email"
+  },
+  "keyType": {
+    "message": "Key type"
+  },
+  "keyCurve": {
+    "message": "Key curve"
+  },
+  "rpName": {
+    "message": "Relying party"
+  },
+  "origin": {
+    "message": "Origin"
   }
 }
diff --git a/apps/browser/src/popup/vault/view.component.html b/apps/browser/src/popup/vault/view.component.html
index db8acc79c32..e844541f8fc 100644
--- a/apps/browser/src/popup/vault/view.component.html
+++ b/apps/browser/src/popup/vault/view.component.html
@@ -414,6 +414,33 @@
           <div *ngIf="cipher.identity.country">{{ cipher.identity.country }}</div>
         </div>
       </div>
+      <!-- Fido2Key -->
+      <div *ngIf="cipher.type == cipherType.Fido2Key">
+        <div class="box-content-row">
+          <span class="row-label">{{ "keyType" | i18n }}</span>
+          {{ cipher.fido2Key.keyType }}
+        </div>
+
+        <div class="box-content-row">
+          <span class="row-label">{{ "keyCurve" | i18n }}</span>
+          {{ cipher.fido2Key.keyCurve }}
+        </div>
+
+        <div class="box-content-row">
+          <span class="row-label">{{ "rpName" | i18n }}</span>
+          {{ cipher.fido2Key.rpName }}
+        </div>
+
+        <div class="box-content-row">
+          <span class="row-label">{{ "username" | i18n }}</span>
+          {{ cipher.fido2Key.userName }}
+        </div>
+
+        <div class="box-content-row">
+          <span class="row-label">{{ "origin" | i18n }}</span>
+          {{ cipher.fido2Key.origin }}
+        </div>
+      </div>
     </div>
   </div>
   <div class="box" *ngIf="cipher.login && cipher.login.hasUris">
diff --git a/libs/common/src/models/api/fido2-key.api.ts b/libs/common/src/models/api/fido2-key.api.ts
index cca96ef7413..1b65ce36399 100644
--- a/libs/common/src/models/api/fido2-key.api.ts
+++ b/libs/common/src/models/api/fido2-key.api.ts
@@ -20,6 +20,7 @@ export class Fido2KeyApi extends BaseResponse {
     this.keyCurve = this.getResponseProperty("KeyCurve");
     this.keyValue = this.getResponseProperty("keyValue");
     this.rpId = this.getResponseProperty("RpId");
+    this.rpName = this.getResponseProperty("RpName");
     this.userHandle = this.getResponseProperty("UserHandle");
     this.userName = this.getResponseProperty("UserName");
     this.origin = this.getResponseProperty("Origin");