mirror of
https://github.com/bitwarden/browser
synced 2025-12-20 10:13:31 +00:00
UIF - Prefer signal & change detection (#16940)
This commit is contained in:
@@ -7,6 +7,8 @@ import { Component } from "@angular/core";
|
||||
* Pass skeleton loaders into the start, default, and end content slots. The content within each slot
|
||||
* is fully customizable.
|
||||
*/
|
||||
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
|
||||
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
|
||||
@Component({
|
||||
selector: "bit-skeleton-group",
|
||||
templateUrl: "./skeleton-group.component.html",
|
||||
|
||||
@@ -10,6 +10,8 @@ import { SkeletonComponent } from "./skeleton.component";
|
||||
* Customize the number of lines represented with the `lines` input. Customize the width
|
||||
* by applying a class to the `bit-skeleton-text` element (i.e. `tw-w-1/2`).
|
||||
*/
|
||||
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
|
||||
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
|
||||
@Component({
|
||||
selector: "bit-skeleton-text",
|
||||
templateUrl: "./skeleton-text.component.html",
|
||||
@@ -27,5 +29,5 @@ export class SkeletonTextComponent {
|
||||
/**
|
||||
* Array-transformed version of the `lines` to loop over
|
||||
*/
|
||||
protected linesArray = computed(() => [...Array(this.lines()).keys()]);
|
||||
protected readonly linesArray = computed(() => [...Array(this.lines()).keys()]);
|
||||
}
|
||||
|
||||
@@ -10,6 +10,8 @@ import { Component, input } from "@angular/core";
|
||||
*
|
||||
* If you're looking to represent lines of text, use the `bit-skeleton-text` helper component.
|
||||
*/
|
||||
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
|
||||
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
|
||||
@Component({
|
||||
selector: "bit-skeleton",
|
||||
templateUrl: "./skeleton.component.html",
|
||||
|
||||
Reference in New Issue
Block a user