bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-20 02:03:39 +00:00
Code Issues Releases Wiki Activity

UIF - Prefer signal & change detection (#16940)

Browse Source
This commit is contained in:
Oscar Hinton
2025-10-21 18:52:40 +02:00
committed by GitHub
parent d3fc20f8b9
commit 65da23feaa
135 changed files with 503 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libs/components/src/stories/kitchen-sink/components/dialog-virtual-scroll-block.component.ts
View File

@@ -7,6 +7,8 @@ import { ScrollLayoutDirective } from "../../../layout";
import { SectionComponent } from "../../../section";
import { TableDataSource, TableModule } from "../../../table";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "dialog-virtual-scroll-block",
standalone: true,

2
libs/components/src/stories/kitchen-sink/components/kitchen-sink-form.component.ts
View File

@@ -7,6 +7,8 @@ import { DialogService } from "../../../dialog";
import { I18nMockService } from "../../../utils/i18n-mock.service";
import { KitchenSinkSharedModule } from "../kitchen-sink-shared.module";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "bit-kitchen-sink-form",
imports: [KitchenSinkSharedModule],

6
libs/components/src/stories/kitchen-sink/components/kitchen-sink-main.component.ts
View File

@@ -8,6 +8,8 @@ import { KitchenSinkForm } from "./kitchen-sink-form.component";
import { KitchenSinkTable } from "./kitchen-sink-table.component";
import { KitchenSinkToggleList } from "./kitchen-sink-toggle-list.component";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
imports: [KitchenSinkSharedModule],
template: `
@@ -85,6 +87,8 @@ class KitchenSinkDialog {
constructor(public dialogRef: DialogRef) {}
}
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "bit-tab-main",
imports: [KitchenSinkSharedModule, KitchenSinkTable, KitchenSinkToggleList, KitchenSinkForm],
@@ -175,7 +179,7 @@ class KitchenSinkDialog {
export class KitchenSinkMainComponent {
constructor(public dialogService: DialogService) {}
protected drawerOpen = signal(false);
protected readonly drawerOpen = signal(false);
openDialog() {
this.dialogService.open(KitchenSinkDialog);

2
libs/components/src/stories/kitchen-sink/components/kitchen-sink-table.component.ts
View File

@@ -2,6 +2,8 @@ import { Component } from "@angular/core";
import { KitchenSinkSharedModule } from "../kitchen-sink-shared.module";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "bit-kitchen-sink-table",
imports: [KitchenSinkSharedModule],

2
libs/components/src/stories/kitchen-sink/components/kitchen-sink-toggle-list.component.ts
View File

@@ -2,6 +2,8 @@ import { Component } from "@angular/core";
import { KitchenSinkSharedModule } from "../kitchen-sink-shared.module";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "bit-kitchen-sink-toggle-list",
imports: [KitchenSinkSharedModule],