diff --git a/apps/web/src/app/admin-console/organizations/policies/base-policy-edit.component.ts b/apps/web/src/app/admin-console/organizations/policies/base-policy-edit.component.ts index eebfadbef30..f659fad7b51 100644 --- a/apps/web/src/app/admin-console/organizations/policies/base-policy-edit.component.ts +++ b/apps/web/src/app/admin-console/organizations/policies/base-policy-edit.component.ts @@ -58,7 +58,7 @@ export abstract class BasePolicyEditDefinition { * If true, the {@link description} will be reused in the policy edit modal. Set this to false if you * have more complex requirements that you will implement in your template instead. **/ - showDescription: boolean = false; + showDescription: boolean = true; /** * A method that determines whether to display this policy in the Admin Console Policies page. diff --git a/apps/web/src/app/admin-console/organizations/policies/policies.component.html b/apps/web/src/app/admin-console/organizations/policies/policies.component.html index 64fb4794037..902c7e79d55 100644 --- a/apps/web/src/app/admin-console/organizations/policies/policies.component.html +++ b/apps/web/src/app/admin-console/organizations/policies/policies.component.html @@ -19,14 +19,12 @@ @if (p.display$(organization, configService) | async) { -
- - @if (policiesEnabledMap.get(p.type)) { - {{ "on" | i18n }} - } -
+ + @if (policiesEnabledMap.get(p.type)) { + {{ "on" | i18n }} + } {{ p.description | i18n }} diff --git a/apps/web/src/app/admin-console/organizations/policies/policies.component.ts b/apps/web/src/app/admin-console/organizations/policies/policies.component.ts index 0dd0b67c189..d13a2097628 100644 --- a/apps/web/src/app/admin-console/organizations/policies/policies.component.ts +++ b/apps/web/src/app/admin-console/organizations/policies/policies.component.ts @@ -1,4 +1,4 @@ -import { ChangeDetectionStrategy, Component, DestroyRef, OnDestroy } from "@angular/core"; +import { ChangeDetectionStrategy, Component, DestroyRef } from "@angular/core"; import { takeUntilDestroyed } from "@angular/core/rxjs-interop"; import { ActivatedRoute } from "@angular/router"; import { combineLatest, Observable, of, switchMap, first, map, shareReplay } from "rxjs"; @@ -14,7 +14,7 @@ import { getUserId } from "@bitwarden/common/auth/services/account.service"; import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service"; import { getById } from "@bitwarden/common/platform/misc"; import { OrganizationId, UserId } from "@bitwarden/common/types/guid"; -import { DialogRef, DialogService } from "@bitwarden/components"; +import { DialogService } from "@bitwarden/components"; import { safeProvider } from "@bitwarden/ui-common"; import { HeaderModule } from "../../../layouts/header/header.module"; @@ -37,8 +37,7 @@ import { POLICY_EDIT_REGISTER } from "./policy-register-token"; ], changeDetection: ChangeDetectionStrategy.OnPush, }) -export class PoliciesComponent implements OnDestroy { - private myDialogRef?: DialogRef; +export class PoliciesComponent { private userId$: Observable = this.accountService.activeAccount$.pipe(getUserId); protected organizationId$: Observable = this.route.params.pipe( @@ -99,10 +98,6 @@ export class PoliciesComponent implements OnDestroy { this.handleLaunchEvent(); } - ngOnDestroy() { - this.myDialogRef?.close(); - } - // Handle policies component launch from Event message private handleLaunchEvent() { combineLatest([ @@ -136,7 +131,7 @@ export class PoliciesComponent implements OnDestroy { edit(policy: BasePolicyEditDefinition, organizationId: OrganizationId) { const dialogComponent: PolicyDialogComponent = policy.editDialogComponent ?? PolicyEditDialogComponent; - this.myDialogRef = dialogComponent.open(this.dialogService, { + dialogComponent.open(this.dialogService, { data: { policy: policy, organizationId: organizationId, diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/master-password.component.html b/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/master-password.component.html index 2267bd5888e..f979c143a3a 100644 --- a/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/master-password.component.html +++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/master-password.component.html @@ -13,24 +13,29 @@ {{ "enforceOnLoginDesc" | i18n }} - - {{ "minComplexityScore" | i18n }} - - - - - - - {{ "minLength" | i18n }} - - +
+ + {{ "minComplexityScore" | i18n }} + + + + + + {{ "minLength" | i18n }} + + +
diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/password-generator.component.html b/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/password-generator.component.html index 372ad3609c0..1300acee471 100644 --- a/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/password-generator.component.html +++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/password-generator.component.html @@ -4,50 +4,56 @@ {{ "turnOn" | i18n }} - - {{ "passwordTypePolicyOverride" | i18n }} - - - - +
+ + {{ "overridePasswordTypePolicy" | i18n }} + + + + +

{{ "password" | i18n }}

- - {{ "minLength" | i18n }} - - - - {{ "minNumbers" | i18n }} - - - - {{ "minSpecial" | i18n }} - - +
+ + {{ "minLength" | i18n }} + + +
+
+ + {{ "minNumbers" | i18n }} + + + + {{ "minSpecial" | i18n }} + + +
{{ "uppercaseLabel" | i18n }} @@ -73,16 +79,18 @@

{{ "passphrase" | i18n }}

- - {{ "minimumNumberOfWords" | i18n }} - - +
+ + {{ "minimumNumberOfWords" | i18n }} + + +
{{ "capitalize" | i18n }} diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialog.component.html b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialog.component.html index 6981802e8e9..6573801ad25 100644 --- a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialog.component.html +++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialog.component.html @@ -1,13 +1,5 @@ -
- - - - {{ policy.name | i18n }} - @if (isPolicyEnabled) { - {{ "on" | i18n }} - } - - + +
) => { - return dialogService.openDrawer( - PolicyEditDialogComponent, - config, - ); + return dialogService.open(PolicyEditDialogComponent, config); }; } diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/auto-confirm-edit-policy-dialog.component.html b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/auto-confirm-edit-policy-dialog.component.html index fd0867a5cd5..4d1db65034d 100644 --- a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/auto-confirm-edit-policy-dialog.component.html +++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/auto-confirm-edit-policy-dialog.component.html @@ -1,5 +1,5 @@ - - + + @let title = (multiStepSubmit | async)[currentStep()]?.titleContent(); @if (title) { @@ -40,16 +40,13 @@ @if (showBadge) { {{ "availableNow" | i18n }} } - + {{ (showBadge ? "autoConfirm" : "editPolicy") | i18n }} @if (!showBadge) { {{ policy.name | i18n }} } - @if (isPolicyEnabled) { - {{ "on" | i18n }} - }
diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/auto-confirm-edit-policy-dialog.component.ts b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/auto-confirm-edit-policy-dialog.component.ts index b5a92671054..f0146225b8d 100644 --- a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/auto-confirm-edit-policy-dialog.component.ts +++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/auto-confirm-edit-policy-dialog.component.ts @@ -287,9 +287,6 @@ export class AutoConfirmPolicyDialogComponent dialogService: DialogService, config: DialogConfig, ) => { - return dialogService.openDrawer( - AutoConfirmPolicyDialogComponent, - config, - ); + return dialogService.open(AutoConfirmPolicyDialogComponent, config); }; } diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/organization-data-ownership-edit-policy-dialog.component.html b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/organization-data-ownership-edit-policy-dialog.component.html index 7b89f4d0acc..73691e94199 100644 --- a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/organization-data-ownership-edit-policy-dialog.component.html +++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/organization-data-ownership-edit-policy-dialog.component.html @@ -1,5 +1,5 @@ - - + + @let title = multiStepSubmit()[currentStep()]?.titleContent(); @if (title) { @@ -35,12 +35,7 @@ - - {{ policy.name | i18n }} - @if (isPolicyEnabled) { - {{ "on" | i18n }} - } - + {{ policy.name | i18n }} diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/organization-data-ownership-edit-policy-dialog.component.ts b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/organization-data-ownership-edit-policy-dialog.component.ts index c62be85287f..7869eab0063 100644 --- a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/organization-data-ownership-edit-policy-dialog.component.ts +++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/organization-data-ownership-edit-policy-dialog.component.ts @@ -216,7 +216,7 @@ export class OrganizationDataOwnershipPolicyDialogComponent }; static open = (dialogService: DialogService, config: DialogConfig) => { - return dialogService.openDrawer( + return dialogService.open( OrganizationDataOwnershipPolicyDialogComponent, config, ); diff --git a/apps/web/src/locales/en/messages.json b/apps/web/src/locales/en/messages.json index 9c7bcfa25b0..4de158a03f8 100644 --- a/apps/web/src/locales/en/messages.json +++ b/apps/web/src/locales/en/messages.json @@ -5445,8 +5445,8 @@ "minimumNumberOfWords": { "message": "Minimum number of words" }, - "passwordTypePolicyOverride": { - "message": "Password type", + "overridePasswordTypePolicy": { + "message": "Password Type", "description": "Name of the password generator policy that overrides the user's password/passphrase selection." }, "userPreference": {