bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-22 19:23:52 +00:00
Code Issues Releases Wiki Activity

[PM-5189] Fixing a weird side issue that appears when a frame within the page triggers a reposition after the inline menu has been built

Browse Source
This commit is contained in:
Cesar Gonzalez
2024-06-06 10:39:25 -05:00
parent 9fe7c2f643
commit 67db794eda
1 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
apps/browser/src/autofill/background/overlay.background.ts
View File

@@ -343,23 +343,21 @@ export class OverlayBackground implements OverlayBackgroundInterface {
return; return;
} }
const subFrameOffsetsForTab = this.subFrameOffsetsForTab[sender.tab.id];
if (!subFrameOffsetsForTab) {
return;
}
if (this.updateInlineMenuPositionTimeout) { if (this.updateInlineMenuPositionTimeout) {
clearTimeout(this.updateInlineMenuPositionTimeout); clearTimeout(this.updateInlineMenuPositionTimeout);
} }
const tabFrameIds = Array.from(subFrameOffsetsForTab.keys()); const subFrameOffsetsForTab = this.subFrameOffsetsForTab[sender.tab.id];
for (const frameId of tabFrameIds) { if (subFrameOffsetsForTab) {
if (frameId === sender.frameId) { const tabFrameIds = Array.from(subFrameOffsetsForTab.keys());
continue; for (const frameId of tabFrameIds) {
} if (frameId === sender.frameId) {
continue;
}
subFrameOffsetsForTab.delete(frameId); subFrameOffsetsForTab.delete(frameId);
await this.buildSubFrameOffsets(sender.tab, frameId, sender.url); await this.buildSubFrameOffsets(sender.tab, frameId, sender.url);
}
} }
this.updateInlineMenuPositionTimeout = setTimeout( this.updateInlineMenuPositionTimeout = setTimeout(