1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-19 09:43:23 +00:00

[CL-295] Use aria-disabled on buttons (#15009)

* Use aria-disabled for button disabled state

* remove import from testing story

* use aria-disabled attr on bitLink button

* remove unnecessary story attrs

* remove disabled attr if on button element

* create caprture click util

* use caprture click util and fix tests

* fix lint errors

* fix event type

* combine click capture and attr modification

* fix lint error. Commit spec changes left out of last commit in error

* inject element ref

* move aria-disabled styles to common

* move disabled logic into util

* fix broken async actions stories

* fix broken tests asserting disabled attr

* have test check for string true vlalue

* fix Signal type

* fix form-field story import

* remove injector left in error

* aria-disable icon buttons

* update form component css selector to look for aria-disabled buttons

* use correct types. pass nativeElement directly

* add JSDoc comment for util function

---------

Co-authored-by: Will Martin <contact@willmartian.com>
This commit is contained in:
Bryan Cunningham
2025-07-08 16:13:25 -04:00
committed by GitHub
parent d5e7f3bd04
commit 682f1f83d9
12 changed files with 175 additions and 73 deletions

View File

@@ -13,6 +13,7 @@ import { IconButtonModule } from "../icon-button";
import { InputModule } from "../input/input.module";
import { I18nMockService } from "../utils/i18n-mock.service";
import { AsyncActionsModule } from "./async-actions.module";
import { BitActionDirective } from "./bit-action.directive";
import { BitSubmitDirective } from "./bit-submit.directive";
import { BitFormButtonDirective } from "./form-button.directive";
@@ -40,6 +41,13 @@ const template = `
@Component({
selector: "app-promise-example",
template,
imports: [
AsyncActionsModule,
ButtonModule,
FormFieldModule,
IconButtonModule,
ReactiveFormsModule,
],
})
class PromiseExampleComponent {
formObj = this.formBuilder.group({
@@ -77,6 +85,13 @@ class PromiseExampleComponent {
@Component({
selector: "app-observable-example",
template,
imports: [
AsyncActionsModule,
ButtonModule,
FormFieldModule,
IconButtonModule,
ReactiveFormsModule,
],
})
class ObservableExampleComponent {
formObj = this.formBuilder.group({
@@ -109,7 +124,6 @@ export default {
title: "Component Library/Async Actions/In Forms",
decorators: [
moduleMetadata({
declarations: [PromiseExampleComponent, ObservableExampleComponent],
imports: [
BitSubmitDirective,
BitFormButtonDirective,
@@ -120,6 +134,8 @@ export default {
ButtonModule,
IconButtonModule,
BitActionDirective,
PromiseExampleComponent,
ObservableExampleComponent,
],
providers: [
{