bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-19 01:33:33 +00:00
Code Issues Releases Wiki Activity

New method to update the last used index (#184)

Browse Source 
Instead of updating it every time you call getNext(), it will be updated in a separate call, to avoid updating the index when the cipher did not auto-fill correctly (e.g wrong frame)
Fixes #1392
This commit is contained in:
Josep Marí
2020-10-09 13:30:55 +02:00
committed by GitHub
parent 9216a8ead7
commit 685636b129
3 changed files with 22 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/models/domain/sortedCiphersCache.ts
View File

@@ -32,6 +32,12 @@ export class SortedCiphersCache {
return this.isCached(url) ? this.sortedCiphersByUrl.get(url).getNext() : null;
}
updateLastUsedIndex(url: string) {
if (this.isCached(url)) {
this.sortedCiphersByUrl.get(url).updateLastUsedIndex();
}
}
clear() {
this.sortedCiphersByUrl.clear();
this.timeouts.clear();
@@ -57,14 +63,20 @@ class Ciphers {
}
getLastLaunched() {
const usedCiphers = this.ciphers.filter(cipher => cipher.localData?.lastLaunched)
const usedCiphers = this.ciphers.filter(cipher => cipher.localData?.lastLaunched);
const sortedCiphers = usedCiphers.sort((x, y) => y.localData.lastLaunched.valueOf() - x.localData.lastLaunched.valueOf());
return sortedCiphers[0];
}
getNextIndex() {
return (this.lastUsedIndex + 1) % this.ciphers.length;
}
getNext() {
const nextIndex = (this.lastUsedIndex + 1) % this.ciphers.length;
this.lastUsedIndex = nextIndex;
return this.ciphers[nextIndex];
return this.ciphers[this.getNextIndex()];
}
updateLastUsedIndex() {
this.lastUsedIndex = this.getNextIndex();
}
}