bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 16:53:34 +00:00
Code Issues Releases Wiki Activity

[PM-5189] Fixing issues found with focusing elements between iframes, as well as fade in of the inline menu in a simultaneous manner for all visual elements

Browse Source
This commit is contained in:
Cesar Gonzalez
2024-05-22 07:32:07 -05:00
parent 2ed62cc6a4
commit 698e68b535
3 changed files with 33 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
apps/browser/src/autofill/background/overlay.background.ts
View File

@@ -343,15 +343,33 @@ export class OverlayBackground implements OverlayBackgroundInterface {
await this.buildSubFrameOffsets(sender.tab, frameId, sender.url); await this.buildSubFrameOffsets(sender.tab, frameId, sender.url);
} }
this.updateInlineMenuPositionTimeout = setTimeout(() => { this.updateInlineMenuPositionTimeout = setTimeout(
if (this.isFieldCurrentlyFocused) { () => this.updateInlineMenuPositionAfterSubFrameRebuild(sender),
void this.updateInlineMenuPosition({ overlayElement: AutofillOverlayElement.List }, sender); 650,
void this.updateInlineMenuPosition( );
{ overlayElement: AutofillOverlayElement.Button }, }
sender,
); private async updateInlineMenuPositionAfterSubFrameRebuild(sender: chrome.runtime.MessageSender) {
} if (!this.isFieldCurrentlyFocused) {
}, 650); return;
}
void this.updateInlineMenuPosition({ overlayElement: AutofillOverlayElement.Button }, sender);
const mostRecentlyFocusedFieldHasValue = await BrowserApi.tabSendMessage(
sender.tab,
{ command: "checkMostRecentlyFocusedFieldHasValue" },
{ frameId: this.focusedFieldData.frameId },
);
if (
mostRecentlyFocusedFieldHasValue &&
(this.checkIsOverlayLoginCiphersPopulated(sender) ||
this.userAuthStatus !== AuthenticationStatus.Unlocked)
) {
return;
}
void this.updateInlineMenuPosition({ overlayElement: AutofillOverlayElement.List }, sender);
} }
/** /**

1
apps/browser/src/autofill/services/abstractions/autofill-overlay-content.service.ts
View File

@@ -23,6 +23,7 @@ export type AutofillOverlayContentExtensionMessageHandlers = {
updateAutofillInlineMenuVisibility: ({ message }: AutofillExtensionMessageParam) => void; updateAutofillInlineMenuVisibility: ({ message }: AutofillExtensionMessageParam) => void;
getSubFrameOffsets: ({ message }: AutofillExtensionMessageParam) => Promise<SubFrameOffsetData>; getSubFrameOffsets: ({ message }: AutofillExtensionMessageParam) => Promise<SubFrameOffsetData>;
getSubFrameOffsetsFromWindowMessage: ({ message }: AutofillExtensionMessageParam) => void; getSubFrameOffsetsFromWindowMessage: ({ message }: AutofillExtensionMessageParam) => void;
checkMostRecentlyFocusedFieldHasValue: () => boolean;
}; };
export interface AutofillOverlayContentService { export interface AutofillOverlayContentService {

5
apps/browser/src/autofill/services/autofill-overlay-content.service.ts
View File

@@ -54,6 +54,7 @@ export class AutofillOverlayContentService implements AutofillOverlayContentServ
getSubFrameOffsets: ({ message }) => this.getSubFrameOffsets(message), getSubFrameOffsets: ({ message }) => this.getSubFrameOffsets(message),
getSubFrameOffsetsFromWindowMessage: ({ message }) => getSubFrameOffsetsFromWindowMessage: ({ message }) =>
this.getSubFrameOffsetsFromWindowMessage(message), this.getSubFrameOffsetsFromWindowMessage(message),
checkMostRecentlyFocusedFieldHasValue: () => this.mostRecentlyFocusedFieldHasValue(),
}; };
/** /**
@@ -859,6 +860,10 @@ export class AutofillOverlayContentService implements AutofillOverlayContentServ
); );
} }
private mostRecentlyFocusedFieldHasValue() {
return Boolean((this.mostRecentlyFocusedField as FillableFormFieldElement)?.value);
}
/** /**
* Sets up global event listeners and the mutation * Sets up global event listeners and the mutation
* observer to facilitate required changes to the * observer to facilitate required changes to the