bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 16:23:44 +00:00
Code Issues Releases Wiki Activity

[EC-598] feat: inform user when no credentials are found

Browse Source
This commit is contained in:
Andreas Coroiu
2023-04-17 11:20:25 +02:00
parent 1ab263e4d9
commit 69e36b972b
5 changed files with 43 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
libs/common/src/fido2/abstractions/fido2-user-interface.service.abstraction.ts
View File

@@ -25,5 +25,6 @@ export abstract class Fido2UserInterfaceSession {
existingCipherIds: string[],
abortController?: AbortController
) => Promise<void>;
informCredentialNotFound: (abortController?: AbortController) => Promise<void>;
close: () => void;
}

27
libs/common/src/fido2/services/fido2-authenticator.service.spec.ts
View File

@@ -218,7 +218,7 @@ describe("FidoAuthenticatorService", () => {
});
/** Devation: Organization ciphers are not checked against excluded credentials, even if the user has access to them. */
it.only("should not inform user of duplication when the excluded credential belongs to an organization", async () => {
it("should not inform user of duplication when the excluded credential belongs to an organization", async () => {
userInterfaceSession.informExcludedCredential.mockResolvedValue();
excludedCipherView.organizationId = "someOrganizationId";
@@ -597,24 +597,35 @@ describe("FidoAuthenticatorService", () => {
});
});
/** Spec: If credentialOptions is now empty, return an error code equivalent to "NotAllowedError" and terminate the operation. */
it("should throw error if no credential exists", async () => {
/**
* Spec: If credentialOptions is now empty, return an error code equivalent to "NotAllowedError" and terminate the operation.
* Deviation: We do not throw error but instead inform the user and allow the user to fallback to browser implementation.
**/
it("should inform user if no credential exists", async () => {
cipherService.getAllDecrypted.mockResolvedValue([]);
userInterfaceSession.informCredentialNotFound.mockResolvedValue();
const result = async () => await authenticator.getAssertion(params);
try {
await authenticator.getAssertion(params);
// eslint-disable-next-line no-empty
} catch {}
await expect(result).rejects.toThrowError(Fido2AutenticatorErrorCode.NotAllowed);
expect(userInterfaceSession.informCredentialNotFound).toHaveBeenCalled();
});
it("should throw error if credential exists but rpId does not match", async () => {
it("should inform user if credential exists but rpId does not match", async () => {
const cipher = await createCipherView({ type: CipherType.Login });
cipher.login.fido2Key.nonDiscoverableId = credentialId;
cipher.login.fido2Key.rpId = "mismatch-rpid";
cipherService.getAllDecrypted.mockResolvedValue([cipher]);
userInterfaceSession.informCredentialNotFound.mockResolvedValue();
const result = async () => await authenticator.getAssertion(params);
try {
await authenticator.getAssertion(params);
// eslint-disable-next-line no-empty
} catch {}
await expect(result).rejects.toThrowError(Fido2AutenticatorErrorCode.NotAllowed);
expect(userInterfaceSession.informCredentialNotFound).toHaveBeenCalled();
});
});

1
libs/common/src/fido2/services/fido2-authenticator.service.ts
View File

@@ -191,6 +191,7 @@ export class Fido2AuthenticatorService implements Fido2AuthenticatorServiceAbstr
}
if (cipherOptions.length === 0) {
await userInterfaceSession.informCredentialNotFound();
throw new Fido2AutenticatorError(Fido2AutenticatorErrorCode.NotAllowed);
}