bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-14 23:45:37 +00:00
Code Issues Releases Wiki Activity

[EC-86] Refactor/rename GroupApiService

Browse Source 
- Re-name GroupApiService to GroupService
 as there is no need for a separate Api service (no sync or local data for admin services)
- Add GroupView for use in the GroupService instead of raw API models
- Update views to use GroupView instead of raw GroupResponse models
This commit is contained in:
Shane Melton
2022-10-17 16:24:46 -07:00
parent 5d438f7111
commit 6accaeaed3
10 changed files with 63 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
libs/angular/src/services/jslib-services.module.ts
View File

@@ -27,7 +27,7 @@ import {
InternalFolderService,
} from "@bitwarden/common/abstractions/folder/folder.service.abstraction";
import { FormValidationErrorsService as FormValidationErrorsServiceAbstraction } from "@bitwarden/common/abstractions/formValidationErrors.service";
import { GroupApiServiceAbstraction } from "@bitwarden/common/abstractions/group";
import { GroupServiceAbstraction } from "@bitwarden/common/abstractions/group";
import { I18nService as I18nServiceAbstraction } from "@bitwarden/common/abstractions/i18n.service";
import { KeyConnectorService as KeyConnectorServiceAbstraction } from "@bitwarden/common/abstractions/keyConnector.service";
import { LogService } from "@bitwarden/common/abstractions/log.service";
@@ -84,7 +84,7 @@ import { FileUploadService } from "@bitwarden/common/services/fileUpload.service
import { FolderApiService } from "@bitwarden/common/services/folder/folder-api.service";
import { FolderService } from "@bitwarden/common/services/folder/folder.service";
import { FormValidationErrorsService } from "@bitwarden/common/services/formValidationErrors.service";
import { GroupApiService } from "@bitwarden/common/services/group/group-api.service";
import { GroupService } from "@bitwarden/common/services/group/group.service";
import { KeyConnectorService } from "@bitwarden/common/services/keyConnector.service";
import { NotificationsService } from "@bitwarden/common/services/notifications.service";
import { OrganizationApiService } from "@bitwarden/common/services/organization/organization-api.service";
@@ -564,8 +564,8 @@ import { ValidationService } from "./validation.service";
deps: [EnvironmentServiceAbstraction, AuthServiceAbstraction, LogService],
},
{
provide: GroupApiServiceAbstraction,
useClass: GroupApiService,
provide: GroupServiceAbstraction,
useClass: GroupService,
deps: [ApiServiceAbstraction],
},
],