mirror of
https://github.com/bitwarden/browser
synced 2026-03-01 02:51:24 +00:00
[CL-1051] Generic closeOnNavigation for drawers (#19031)
Exposes closeOnNavigation from cdk config and implements a drawer close solution on navigation. More complex scenarios may still require custom handling. DialogService is referenced in imported components in some tests meaning we need to use overrideProvider rather than providers.
This commit is contained in:
@@ -86,7 +86,6 @@ describe("VaultItemDialogComponent", () => {
|
||||
{ provide: I18nService, useValue: { t: (key: string) => key } },
|
||||
{ provide: DIALOG_DATA, useValue: { ...baseParams } },
|
||||
{ provide: DialogRef, useValue: {} },
|
||||
{ provide: DialogService, useValue: {} },
|
||||
{
|
||||
provide: ToastService,
|
||||
useValue: {
|
||||
@@ -173,7 +172,9 @@ describe("VaultItemDialogComponent", () => {
|
||||
{ provide: SyncService, useValue: {} },
|
||||
{ provide: CipherRiskService, useValue: {} },
|
||||
],
|
||||
}).compileComponents();
|
||||
})
|
||||
.overrideProvider(DialogService, { useValue: {} })
|
||||
.compileComponents();
|
||||
|
||||
fixture = TestBed.createComponent(TestVaultItemDialogComponent);
|
||||
component = fixture.componentInstance;
|
||||
|
||||
@@ -87,7 +87,6 @@ describe("AddEditComponentV2", () => {
|
||||
{ provide: DIALOG_DATA, useValue: mockParams },
|
||||
{ provide: DialogRef, useValue: dialogRef },
|
||||
{ provide: I18nService, useValue: { t: jest.fn().mockReturnValue("login") } },
|
||||
{ provide: DialogService, useValue: dialogService },
|
||||
{ provide: CipherService, useValue: cipherService },
|
||||
{ provide: MessagingService, useValue: messagingService },
|
||||
{ provide: OrganizationService, useValue: organizationService },
|
||||
@@ -105,7 +104,9 @@ describe("AddEditComponentV2", () => {
|
||||
},
|
||||
{ provide: AccountService, useValue: accountService },
|
||||
],
|
||||
}).compileComponents();
|
||||
})
|
||||
.overrideProvider(DialogService, { useValue: dialogService })
|
||||
.compileComponents();
|
||||
|
||||
fixture = TestBed.createComponent(AddEditComponentV2);
|
||||
component = fixture.componentInstance;
|
||||
|
||||
Reference in New Issue
Block a user