bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-12 14:23:32 +00:00
Code Issues Releases Wiki Activity

Removing the notifications feature flag and logic (#15551)

Browse Source
This commit is contained in:
Tom
2025-07-23 09:51:02 -04:00
committed by GitHub
parent e8629e5e1b
commit 6b76581918
3 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
bitwarden_license/bit-web/src/app/dirt/access-intelligence/critical-applications.component.html
View File

@@ -29,7 +29,6 @@
<div class="tw-flex tw-justify-between tw-mb-4"> <div class="tw-flex tw-justify-between tw-mb-4">
<h2 bitTypography="h2">{{ "criticalApplications" | i18n }}</h2> <h2 bitTypography="h2">{{ "criticalApplications" | i18n }}</h2>
<button <button
*ngIf="isNotificationsFeatureEnabled"
bitButton bitButton
buttonType="primary" buttonType="primary"
type="button" type="button"

6
bitwarden_license/bit-web/src/app/dirt/access-intelligence/critical-applications.component.ts
View File

@@ -16,7 +16,6 @@ import {
ApplicationHealthReportDetailWithCriticalFlagAndCipher, ApplicationHealthReportDetailWithCriticalFlagAndCipher,
ApplicationHealthReportSummary, ApplicationHealthReportSummary,
} from "@bitwarden/bit-common/dirt/reports/risk-insights/models/password-health"; } from "@bitwarden/bit-common/dirt/reports/risk-insights/models/password-health";
import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum";
import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service"; import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service";
import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service"; import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
import { CipherId, OrganizationId } from "@bitwarden/common/types/guid"; import { CipherId, OrganizationId } from "@bitwarden/common/types/guid";
@@ -63,14 +62,9 @@ export class CriticalApplicationsComponent implements OnInit {
protected organizationId: string; protected organizationId: string;
protected applicationSummary = {} as ApplicationHealthReportSummary; protected applicationSummary = {} as ApplicationHealthReportSummary;
noItemsIcon = Icons.Security; noItemsIcon = Icons.Security;
isNotificationsFeatureEnabled: boolean = false;
enableRequestPasswordChange = false; enableRequestPasswordChange = false;
async ngOnInit() { async ngOnInit() {
this.isNotificationsFeatureEnabled = await this.configService.getFeatureFlag(
FeatureFlag.EnableRiskInsightsNotifications,
);
this.organizationId = this.activatedRoute.snapshot.paramMap.get("organizationId") ?? ""; this.organizationId = this.activatedRoute.snapshot.paramMap.get("organizationId") ?? "";
combineLatest([ combineLatest([

6
libs/common/src/enums/feature-flag.enum.ts
View File

@@ -35,9 +35,6 @@ export enum FeatureFlag {
AllowTrialLengthZero = "pm-20322-allow-trial-length-0", AllowTrialLengthZero = "pm-20322-allow-trial-length-0",
PM21881_ManagePaymentDetailsOutsideCheckout = "pm-21881-manage-payment-details-outside-checkout", PM21881_ManagePaymentDetailsOutsideCheckout = "pm-21881-manage-payment-details-outside-checkout",
/* Data Insights and Reporting */
EnableRiskInsightsNotifications = "enable-risk-insights-notifications",
/* Key Management */ /* Key Management */
PrivateKeyRegeneration = "pm-12241-private-key-regeneration", PrivateKeyRegeneration = "pm-12241-private-key-regeneration",
PM4154_BulkEncryptionService = "PM-4154-bulk-encryption-service", PM4154_BulkEncryptionService = "PM-4154-bulk-encryption-service",
@@ -89,9 +86,6 @@ export const DefaultFeatureFlagValue = {
[FeatureFlag.MacOsNativeCredentialSync]: FALSE, [FeatureFlag.MacOsNativeCredentialSync]: FALSE,
[FeatureFlag.WindowsDesktopAutotype]: FALSE, [FeatureFlag.WindowsDesktopAutotype]: FALSE,
/* Data Insights and Reporting */
[FeatureFlag.EnableRiskInsightsNotifications]: FALSE,
/* Tools */ /* Tools */
[FeatureFlag.DesktopSendUIRefresh]: FALSE, [FeatureFlag.DesktopSendUIRefresh]: FALSE,