bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-11 05:43:41 +00:00
Code Issues Releases Wiki Activity

fix: add world: MAIN to Firefox page script registration (#17466)

Browse Source 
* chore: update @types/firefox-webext-browser

* fix: add world: MAIN to Firefox page script registration

* review: add world property to registration type
This commit is contained in:
Addison Beck
2025-11-19 15:13:41 -05:00
committed by GitHub
parent e44ab1b411
commit 6d1c474fc5
5 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
apps/browser/src/autofill/fido2/background/abstractions/fido2.background.ts
View File

@@ -13,6 +13,7 @@ type SharedFido2ScriptRegistrationOptions = SharedFido2ScriptInjectionDetails &
matches: string[]; matches: string[];
excludeMatches: string[]; excludeMatches: string[];
allFrames: true; allFrames: true;
world?: "MAIN" | "ISOLATED";
}; };
type Fido2ExtensionMessage = { type Fido2ExtensionMessage = {

1
apps/browser/src/autofill/fido2/background/fido2.background.spec.ts
View File

@@ -203,6 +203,7 @@ describe("Fido2Background", () => {
{ file: Fido2ContentScript.PageScriptDelayAppend }, { file: Fido2ContentScript.PageScriptDelayAppend },
{ file: Fido2ContentScript.ContentScript }, { file: Fido2ContentScript.ContentScript },
], ],
world: "MAIN",
...sharedRegistrationOptions, ...sharedRegistrationOptions,
}); });
}); });

1
apps/browser/src/autofill/fido2/background/fido2.background.ts
View File

@@ -176,6 +176,7 @@ export class Fido2Background implements Fido2BackgroundInterface {
{ file: await this.getFido2PageScriptAppendFileName() }, { file: await this.getFido2PageScriptAppendFileName() },
{ file: Fido2ContentScript.ContentScript }, { file: Fido2ContentScript.ContentScript },
], ],
world: "MAIN",
...this.sharedRegistrationOptions, ...this.sharedRegistrationOptions,
}); });
} }

8
package-lock.json generated
View File

@@ -101,7 +101,7 @@
"@storybook/web-components-webpack5": "8.6.12", "@storybook/web-components-webpack5": "8.6.12",
"@tailwindcss/container-queries": "0.1.1", "@tailwindcss/container-queries": "0.1.1",
"@types/chrome": "0.1.28", "@types/chrome": "0.1.28",
"@types/firefox-webext-browser": "120.0.4", "@types/firefox-webext-browser": "143.0.0",
"@types/inquirer": "8.2.10", "@types/inquirer": "8.2.10",
"@types/jest": "29.5.14", "@types/jest": "29.5.14",
"@types/jsdom": "21.1.7", "@types/jsdom": "21.1.7",
@@ -14083,9 +14083,9 @@
"license": "MIT" "license": "MIT"
}, },
"node_modules/@types/firefox-webext-browser": { "node_modules/@types/firefox-webext-browser": {
"version": "120.0.4", "version": "143.0.0",
"resolved": "https://registry.npmjs.org/@types/firefox-webext-browser/-/firefox-webext-browser-120.0.4.tgz", "resolved": "https://registry.npmjs.org/@types/firefox-webext-browser/-/firefox-webext-browser-143.0.0.tgz",
"integrity": "sha512-lBrpf08xhiZBigrtdQfUaqX1UauwZ+skbFiL8u2Tdra/rklkKadYmIzTwkNZSWtuZ7OKpFqbE2HHfDoFqvZf6w==", "integrity": "sha512-865dYKMOP0CllFyHmgXV4IQgVL51OSQQCwSoihQ17EwugePKFSAZRc0EI+y7Ly4q7j5KyURlA7LgRpFieO4JOw==",
"dev": true, "dev": true,
"license": "MIT" "license": "MIT"
}, },

2
package.json
View File

@@ -64,7 +64,7 @@
"@storybook/web-components-webpack5": "8.6.12", "@storybook/web-components-webpack5": "8.6.12",
"@tailwindcss/container-queries": "0.1.1", "@tailwindcss/container-queries": "0.1.1",
"@types/chrome": "0.1.28", "@types/chrome": "0.1.28",
"@types/firefox-webext-browser": "120.0.4", "@types/firefox-webext-browser": "143.0.0",
"@types/inquirer": "8.2.10", "@types/inquirer": "8.2.10",
"@types/jest": "29.5.14", "@types/jest": "29.5.14",
"@types/jsdom": "21.1.7", "@types/jsdom": "21.1.7",