bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-19 17:53:39 +00:00
Code Issues Releases Wiki Activity

[PM-5189] Refactoring implementation

Browse Source
This commit is contained in:
Cesar Gonzalez
2024-06-11 09:33:28 -05:00
parent d43b5359c9
commit 6ec6310bb4
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
apps/browser/src/autofill/overlay/inline-menu/content/autofill-inline-menu-content.service.ts
View File

@@ -37,8 +37,7 @@ export class AutofillInlineMenuContentService implements AutofillInlineMenuConte
private readonly _extensionMessageHandlers: InlineMenuExtensionMessageHandlers = { private readonly _extensionMessageHandlers: InlineMenuExtensionMessageHandlers = {
closeAutofillInlineMenu: ({ message }) => this.removeInlineMenu(message), closeAutofillInlineMenu: ({ message }) => this.removeInlineMenu(message),
appendAutofillInlineMenuToDom: ({ message }) => this.appendInlineMenuElements(message), appendAutofillInlineMenuToDom: ({ message }) => this.appendInlineMenuElements(message),
toggleAutofillInlineMenuHidden: ({ message }) => toggleAutofillInlineMenuHidden: ({ message }) => this.toggleInlineMenuHidden(message),
this.toggleInlineMenuHidden(message.isInlineMenuHidden),
checkIsAutofillInlineMenuButtonVisible: () => this.isInlineMenuButtonVisible(), checkIsAutofillInlineMenuButtonVisible: () => this.isInlineMenuButtonVisible(),
checkIsAutofillInlineMenuListVisible: () => this.isInlineMenuListVisible(), checkIsAutofillInlineMenuListVisible: () => this.isInlineMenuListVisible(),
}; };
@@ -66,11 +65,12 @@ export class AutofillInlineMenuContentService implements AutofillInlineMenuConte
/** /**
* Sends a message that facilitates hiding the inline menu elements. * Sends a message that facilitates hiding the inline menu elements.
* *
* @param isHidden - Indicates if the inline menu elements should be hidden. * @param message - The message that contains the visibility state of the inline menu elements.
*/ */
private toggleInlineMenuHidden(isHidden: boolean) { private toggleInlineMenuHidden(message: AutofillExtensionMessage) {
this.isButtonVisible = !!this.buttonElement && !isHidden; const { isInlineMenuHidden } = message;
this.isListVisible = !!this.listElement && !isHidden; this.isButtonVisible = !!this.buttonElement && !isInlineMenuHidden;
this.isListVisible = !!this.listElement && !isInlineMenuHidden;
} }
/** /**
@@ -419,6 +419,7 @@ export class AutofillInlineMenuContentService implements AutofillInlineMenuConte
return false; return false;
} }
destroy() { destroy() {
this.documentElementMutationObserver?.disconnect(); this.documentElementMutationObserver?.disconnect();
this.removeInlineMenu(); this.removeInlineMenu();