bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-22 19:23:52 +00:00
Code Issues Releases Wiki Activity

PM-22143 Refactor TS enums to be const objects (Send specific enums) (#16399)

Browse Source
This commit is contained in:
John Harrington
2025-11-26 15:08:59 -07:00
committed by GitHub
parent 8522b6b87a
commit 6f5491f7dc
9 changed files with 126 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
apps/browser/src/tools/popup/send-v2/add-edit/send-add-edit.component.ts
View File

@@ -41,7 +41,12 @@ import { SendFilePopoutDialogContainerComponent } from "../send-file-popout-dial
class QueryParams {
constructor(params: Params) {
this.sendId = params.sendId;
this.type = parseInt(params.type, 10);
const sendTypeValue = parseInt(params.type, 10);
if (sendTypeValue === SendType.Text || sendTypeValue === SendType.File) {
this.type = sendTypeValue;
} else {
throw new Error(`Invalid SendType: ${params.type}`);
}
}
/**

2
apps/browser/src/tools/popup/send-v2/send-v2.component.spec.ts
View File

@@ -37,7 +37,7 @@ import { PopupHeaderComponent } from "../../../platform/popup/layout/popup-heade
import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.component";
import { PopupRouterCacheService } from "../../../platform/popup/view-cache/popup-router-cache.service";
import { SendV2Component, SendState } from "./send-v2.component";
import { SendState, SendV2Component } from "./send-v2.component";
describe("SendV2Component", () => {
let component: SendV2Component;

23
apps/browser/src/tools/popup/send-v2/send-v2.component.ts
View File

@@ -38,12 +38,16 @@ import { PopupHeaderComponent } from "../../../platform/popup/layout/popup-heade
import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.component";
import { VaultFadeInOutSkeletonComponent } from "../../../vault/popup/components/vault-fade-in-out-skeleton/vault-fade-in-out-skeleton.component";
// FIXME: update to use a const object instead of a typescript enum
// eslint-disable-next-line @bitwarden/platform/no-enums
export enum SendState {
Empty,
NoResults,
}
/** A state of the Send list UI. */
export const SendState = Object.freeze({
/** No sends exist for the current filter (file or text). */
Empty: "Empty",
/** Sends exist, but none match the current filter/search. */
NoResults: "NoResults",
} as const);
/** A state of the Send list UI. */
export type SendState = (typeof SendState)[keyof typeof SendState];
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@@ -114,6 +118,11 @@ export class SendV2Component implements OnDestroy {
protected sendsDisabled = false;
private readonly sendTypeTitles: Record<SendType, string> = {
[SendType.File]: "fileSends",
[SendType.Text]: "textSends",
};
constructor(
protected sendItemsService: SendItemsService,
protected sendListFiltersService: SendListFiltersService,
@@ -130,7 +139,7 @@ export class SendV2Component implements OnDestroy {
.pipe(takeUntilDestroyed())
.subscribe(([emptyList, noFilteredResults, currentFilter]) => {
if (currentFilter?.sendType !== null) {
this.title = `${this.sendType[currentFilter.sendType].toLowerCase()}Sends`;
this.title = this.sendTypeTitles[currentFilter.sendType] ?? "allSends";
} else {
this.title = "allSends";
}