bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 08:13:42 +00:00
Code Issues Releases Wiki Activity

add new memory concept to crypto service calls in cli

Browse Source
This commit is contained in:
Jacob Fink
2023-05-30 11:24:12 -04:00
parent 4772166e83
commit 711d643d68
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
apps/cli/src/auth/commands/login.command.ts
View File

@@ -475,8 +475,8 @@ export class LoginCommand {
/** /**
* Collect new master password and hint from the CLI. The collected password * Collect new master password and hint from the CLI. The collected password
* is validated against any applicable master password policies and a new encryption * is validated against any applicable master password policies, a new master
* key is generated * key is generated, and we use it to re-encrypt the user symmetric key
* @param prompt - Message that is displayed during the initial prompt * @param prompt - Message that is displayed during the initial prompt
* @param error * @param error
*/ */
@@ -576,7 +576,10 @@ export class LoginCommand {
const newPasswordHash = await this.cryptoService.hashPassword(masterPassword, newMasterKey); const newPasswordHash = await this.cryptoService.hashPassword(masterPassword, newMasterKey);
// Grab user's symmetric key // Grab user's symmetric key
const userSymKey = await this.cryptoService.getUserKey(); const userSymKey = await this.cryptoService.getUserKeyFromMemory();
if (!userSymKey) {
throw new Error("User key not found.");
}
// Re-encrypt user's symmetric key with new master key // Re-encrypt user's symmetric key with new master key
const newUserSymKey = await this.cryptoService.encryptUserSymKeyWithMasterKey( const newUserSymKey = await this.cryptoService.encryptUserSymKeyWithMasterKey(

2
apps/cli/src/vault/create.command.ts
View File

@@ -126,7 +126,7 @@ export class CreateCommand {
return Response.error("Premium status is required to use this feature."); return Response.error("Premium status is required to use this feature.");
} }
const userSymKey = await this.cryptoService.getUserKey(); const userSymKey = await this.cryptoService.getUserKeyFromMemory();
if (userSymKey == null) { if (userSymKey == null) {
return Response.error( return Response.error(
"You must update your encryption key before you can use this feature. " + "You must update your encryption key before you can use this feature. " +