bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-11 05:43:41 +00:00
Code Issues Releases Wiki Activity

Removes deprecated keypress event. (#17058)

Browse Source
This commit is contained in:
Miles Blackwood
2025-10-28 11:09:29 -04:00
committed by GitHub
parent 6505ce05db
commit 714daa5779
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
apps/browser/src/autofill/services/insert-autofill-content.service.spec.ts
View File

@@ -26,7 +26,6 @@ const eventsToTest = [
EVENTS.CHANGE, EVENTS.CHANGE,
EVENTS.INPUT, EVENTS.INPUT,
EVENTS.KEYDOWN, EVENTS.KEYDOWN,
EVENTS.KEYPRESS,
EVENTS.KEYUP, EVENTS.KEYUP,
"blur", "blur",
"click", "click",
@@ -1044,13 +1043,13 @@ describe("InsertAutofillContentService", () => {
}); });
describe("simulateUserKeyboardEventInteractions", () => { describe("simulateUserKeyboardEventInteractions", () => {
it("will trigger `keydown`, `keypress`, and `keyup` events on the passed element", () => { it("will trigger `keydown` and `keyup` events on the passed element", () => {
const inputElement = document.querySelector('input[type="text"]') as HTMLInputElement; const inputElement = document.querySelector('input[type="text"]') as HTMLInputElement;
jest.spyOn(inputElement, "dispatchEvent"); jest.spyOn(inputElement, "dispatchEvent");
insertAutofillContentService["simulateUserKeyboardEventInteractions"](inputElement); insertAutofillContentService["simulateUserKeyboardEventInteractions"](inputElement);
[EVENTS.KEYDOWN, EVENTS.KEYPRESS, EVENTS.KEYUP].forEach((eventName) => { [EVENTS.KEYDOWN, EVENTS.KEYUP].forEach((eventName) => {
expect(inputElement.dispatchEvent).toHaveBeenCalledWith( expect(inputElement.dispatchEvent).toHaveBeenCalledWith(
new KeyboardEvent(eventName, { bubbles: true }), new KeyboardEvent(eventName, { bubbles: true }),
); );

2
apps/browser/src/autofill/services/insert-autofill-content.service.ts
View File

@@ -349,7 +349,7 @@ class InsertAutofillContentService implements InsertAutofillContentServiceInterf
* @private * @private
*/ */
private simulateUserKeyboardEventInteractions(element: FormFieldElement): void { private simulateUserKeyboardEventInteractions(element: FormFieldElement): void {
const simulatedKeyboardEvents = [EVENTS.KEYDOWN, EVENTS.KEYPRESS, EVENTS.KEYUP]; const simulatedKeyboardEvents = [EVENTS.KEYDOWN, EVENTS.KEYUP];
for (let index = 0; index < simulatedKeyboardEvents.length; index++) { for (let index = 0; index < simulatedKeyboardEvents.length; index++) {
element.dispatchEvent(new KeyboardEvent(simulatedKeyboardEvents[index], { bubbles: true })); element.dispatchEvent(new KeyboardEvent(simulatedKeyboardEvents[index], { bubbles: true }));
} }