bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-19 01:33:33 +00:00
Code Issues Releases Wiki Activity

[PM-329] Detangle SearchService & CipherService (#4838)

Browse Source 
* Remove Circular Dependency

* Fix Vault Searching

* Remove Unused cipherServiceOptions

* Add searchService Parameter to CipherService

* Fix instantiation of CipherService in test
This commit is contained in:
Justin Baur
2023-04-07 11:11:20 -04:00
committed by GitHub
parent 36de1c8e32
commit 7263579eaf
20 changed files with 52 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
apps/desktop/src/vault/app/vault/vault-items.component.ts
View File

@@ -2,6 +2,7 @@ import { Component } from "@angular/core";
import { VaultItemsComponent as BaseVaultItemsComponent } from "@bitwarden/angular/vault/components/vault-items.component";
import { SearchService } from "@bitwarden/common/abstractions/search.service";
import { CipherService } from "@bitwarden/common/vault/abstractions/cipher.service";
import { CipherView } from "@bitwarden/common/vault/models/view/cipher.view";
import { SearchBarService } from "../../../app/layout/search/search-bar.service";
@@ -12,8 +13,12 @@ import { SearchBarService } from "../../../app/layout/search/search-bar.service"
})
// eslint-disable-next-line rxjs-angular/prefer-takeuntil
export class VaultItemsComponent extends BaseVaultItemsComponent {
constructor(searchService: SearchService, searchBarService: SearchBarService) {
super(searchService);
constructor(
searchService: SearchService,
searchBarService: SearchBarService,
cipherService: CipherService
) {
super(searchService, cipherService);
// eslint-disable-next-line rxjs-angular/prefer-takeuntil
searchBarService.searchText$.subscribe((searchText) => {