[PM-21546] Migrate from enum to constant object (#14975)

* add generic `union-of-values` helper

* migrate `GeneratorDialogAction` to a constant

* migrate `VaultState` to a constant

* migrate `AtRiskCarouselDialogResult` to a constant

* migrate `CredentialGeneratorDialogAction` to a constant

* migrate `FolderAddEditDialogResult` to a constant

* migrate `ViewCipherDialogResult` to a constant

* migrate `VisibleVaultBanner` to a constant

* migrate `VaultFilterLabel` to a constant

* migrate `WebVaultGeneratorDialogResult` to a constant

* migrate `BulkDeleteDialogResult` to a constant

* migrate `BulkMoveDialogResult` to a constant

* migrate `AddEditCipherDialogResult` to a constant

* migrate `VaultItemDialogResult` to a constant

* migrate `BrowserPromptState` to a constant

* migrate `NudgeType` to a constant

* migrate `SecurityTaskStatus` to a constant

* migrate `CipherRepromptType` to a constant

* migrate `SecureNoteType` to a constant

* migrate `FieldType` to a constant

* migrate `LinkedIdType` to a constant

* migrate `CollectionAssignmentResult` to a constant

* migrate `AddEditFolderDialogResult` to a constant

* migrate `AttachmentDialogResult` to a constant

* fix CipherType in delete organization dialog

* fix `in` statement in VaultFilter

* Fix build errors across enum updates

* fix two more CipherType castings

* update CipherResponse `CipherType`

* define type for `fieldType` parameter

* refine how `cipherTypeNames` is generated and add utility function for grabbing cipher type name

* use `CipherType` rather than `number`

* add stricter typing for `FieldType`

* add fixme for `CipherType` to be ADR-0025 compliant

* remove error throw for `toCipherTypeName` and instead update typing to have `| undefined`

* add helpers for CipherType conversions

* prefer `undefined`

apps/desktop/src/vault/app/vault/credential-generator-dialog.component.ts

@@ -3,6 +3,7 @@ import { Component, Inject } from "@angular/core";
 
 import { JslibModule } from "@bitwarden/angular/jslib.module";
 import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
+import { UnionOfValues } from "@bitwarden/common/vault/types/union-of-values";
 import {
   DIALOG_DATA,
   ButtonModule,
@@ -31,12 +32,12 @@ export interface CredentialGeneratorDialogResult {
   generatedValue?: string;
 }
 
-// FIXME: update to use a const object instead of a typescript enum
-// eslint-disable-next-line @bitwarden/platform/no-enums
-export enum CredentialGeneratorDialogAction {
-  Selected = "selected",
-  Canceled = "canceled",
-}
+export const CredentialGeneratorDialogAction = {
+  Selected: "selected",
+  Canceled: "canceled",
+} as const;
+
+type CredentialGeneratorDialogAction = UnionOfValues<typeof CredentialGeneratorDialogAction>;
 
 @Component({
   selector: "credential-generator-dialog",

apps/desktop/src/vault/app/vault/vault-v2.component.ts

@@ -34,7 +34,7 @@ import { FolderService } from "@bitwarden/common/vault/abstractions/folder/folde
 import { PremiumUpgradePromptService } from "@bitwarden/common/vault/abstractions/premium-upgrade-prompt.service";
 import { TotpService } from "@bitwarden/common/vault/abstractions/totp.service";
 import { ViewPasswordHistoryService } from "@bitwarden/common/vault/abstractions/view-password-history.service";
-import { CipherType } from "@bitwarden/common/vault/enums";
+import { CipherType, toCipherType } from "@bitwarden/common/vault/enums";
 import { CipherRepromptType } from "@bitwarden/common/vault/enums/cipher-reprompt-type";
 import { CipherView } from "@bitwarden/common/vault/models/view/cipher.view";
 import {
@@ -323,6 +323,7 @@ export class VaultV2Component implements OnInit, OnDestroy {
 
   async load() {
     const params = await firstValueFrom(this.route.queryParams).catch();
+    const paramCipherAddType = toCipherType(params.addType);
     if (params.cipherId) {
       const cipherView = new CipherView();
       cipherView.id = params.cipherId;
@@ -333,17 +334,15 @@ export class VaultV2Component implements OnInit, OnDestroy {
       } else {
         await this.viewCipher(cipherView).catch(() => {});
       }
-    } else if (params.action === "add") {
-      this.addType = Number(params.addType);
+    } else if (params.action === "add" && paramCipherAddType) {
+      this.addType = paramCipherAddType;
       await this.addCipher(this.addType).catch(() => {});
     }
 
+    const paramCipherType = toCipherType(params.type);
     this.activeFilter = new VaultFilter({
       status: params.deleted ? "trash" : params.favorites ? "favorites" : "all",
-      cipherType:
-        params.action === "add" || params.type == null
-          ? undefined
-          : (parseInt(params.type) as CipherType),
+      cipherType: params.action === "add" || paramCipherType == null ? undefined : paramCipherType,
       selectedFolderId: params.folderId,
       selectedCollectionId: params.selectedCollectionId,
       selectedOrganizationId: params.selectedOrganizationId,

apps/desktop/src/vault/app/vault/vault.component.ts

@@ -31,7 +31,7 @@ import { CipherId, UserId } from "@bitwarden/common/types/guid";
 import { CipherService } from "@bitwarden/common/vault/abstractions/cipher.service";
 import { FolderService } from "@bitwarden/common/vault/abstractions/folder/folder.service.abstraction";
 import { TotpService } from "@bitwarden/common/vault/abstractions/totp.service";
-import { CipherType } from "@bitwarden/common/vault/enums";
+import { CipherType, toCipherType } from "@bitwarden/common/vault/enums";
 import { CipherRepromptType } from "@bitwarden/common/vault/enums/cipher-reprompt-type";
 import { CipherView } from "@bitwarden/common/vault/models/view/cipher.view";
 import { DialogService, ToastService } from "@bitwarden/components";
@@ -282,16 +282,16 @@ export class VaultComponent implements OnInit, OnDestroy {
           await this.viewCipher(cipherView);
         }
       } else if (params.action === "add") {
-        this.addType = Number(params.addType);
+        this.addType = toCipherType(params.addType);
         // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
         // eslint-disable-next-line @typescript-eslint/no-floating-promises
         this.addCipher(this.addType);
       }
 
+      const paramCipherType = toCipherType(params.type);
       this.activeFilter = new VaultFilter({
         status: params.deleted ? "trash" : params.favorites ? "favorites" : "all",
-        cipherType:
-          params.action === "add" || params.type == null ? null : parseInt(params.type, null),
+        cipherType: params.action === "add" || paramCipherType == null ? null : paramCipherType,
         selectedFolderId: params.folderId,
         selectedCollectionId: params.selectedCollectionId,
         selectedOrganizationId: params.selectedOrganizationId,