From 78911732fb5e119d6cadc38728486948ad3cb972 Mon Sep 17 00:00:00 2001 From: Cesar Gonzalez Date: Fri, 7 Jun 2024 10:32:33 -0500 Subject: [PATCH] [PM-5189] Refactoring implementation --- .../autofill/background/overlay.background.ts | 21 ++++++------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/apps/browser/src/autofill/background/overlay.background.ts b/apps/browser/src/autofill/background/overlay.background.ts index 608eff6a67e..245b1414c72 100644 --- a/apps/browser/src/autofill/background/overlay.background.ts +++ b/apps/browser/src/autofill/background/overlay.background.ts @@ -484,12 +484,10 @@ export class OverlayBackground implements OverlayBackgroundInterface { sender: chrome.runtime.MessageSender, { forceCloseAutofillInlineMenu, overlayElement }: CloseInlineMenuMessage = {}, ) { + const command = "closeInlineMenu"; + const sendOptions = { frameId: 0 }; if (forceCloseAutofillInlineMenu) { - void BrowserApi.tabSendMessage( - sender.tab, - { command: "closeInlineMenu", overlayElement }, - { frameId: 0 }, - ); + void BrowserApi.tabSendMessage(sender.tab, { command, overlayElement }, sendOptions); return; } @@ -500,20 +498,13 @@ export class OverlayBackground implements OverlayBackgroundInterface { if (this.isFieldCurrentlyFilling) { void BrowserApi.tabSendMessage( sender.tab, - { - command: "closeInlineMenu", - overlayElement: AutofillOverlayElement.List, - }, - { frameId: 0 }, + { command, overlayElement: AutofillOverlayElement.List }, + sendOptions, ); return; } - void BrowserApi.tabSendMessage( - sender.tab, - { command: "closeInlineMenu", overlayElement }, - { frameId: 0 }, - ); + void BrowserApi.tabSendMessage(sender.tab, { command, overlayElement }, sendOptions); } /**