bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-12 14:23:32 +00:00
Code Issues Releases Wiki Activity

Fix table header sort indicator and enable drawer open on row click (#16439) (#16440)

Browse Source 
Co-authored-by: Maximilian Power <post@maximilianpower.com>
This commit is contained in:
Vijay Oommen
2025-09-19 10:01:46 -05:00
committed by GitHub
parent 012ff03bef
commit 792f7e9c55
1 changed files with 51 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
bitwarden_license/bit-web/src/app/dirt/access-intelligence/app-table-row-scrollable.component.html
View File

@@ -4,7 +4,9 @@
<th></th> <th></th>
<th bitCell></th> <th bitCell></th>
<th bitSortable="applicationName" bitCell>{{ "application" | i18n }}</th> <th bitSortable="applicationName" bitCell>{{ "application" | i18n }}</th>
<th bitSortable="atRiskPasswordCount" bitCell>{{ "atRiskPasswords" | i18n }}</th> <th bitSortable="atRiskPasswordCount" bitCell default="desc">
{{ "atRiskPasswords" | i18n }}
</th>
<th bitSortable="passwordCount" bitCell>{{ "totalPasswords" | i18n }}</th> <th bitSortable="passwordCount" bitCell>{{ "totalPasswords" | i18n }}</th>
<th bitSortable="atRiskMemberCount" bitCell>{{ "atRiskMembers" | i18n }}</th> <th bitSortable="atRiskMemberCount" bitCell>{{ "atRiskMembers" | i18n }}</th>
<th bitSortable="memberCount" bitCell>{{ "totalMembers" | i18n }}</th> <th bitSortable="memberCount" bitCell>{{ "totalMembers" | i18n }}</th>
@@ -14,6 +16,7 @@
bitCell bitCell
*ngIf="showRowCheckBox" *ngIf="showRowCheckBox"
[ngClass]="{ 'tw-bg-primary-100': isDrawerIsOpenForThisRecord(row.applicationName) }" [ngClass]="{ 'tw-bg-primary-100': isDrawerIsOpenForThisRecord(row.applicationName) }"
appStopProp
> >
<input <input
bitCheckbox bitCheckbox
@@ -31,21 +34,42 @@
> >
<i class="bwi bwi-star-f" *ngIf="row.isMarkedAsCritical"></i> <i class="bwi bwi-star-f" *ngIf="row.isMarkedAsCritical"></i>
</td> </td>
<td bitCell>
<app-vault-icon *ngIf="row.ciphers.length > 0" [cipher]="row.ciphers[0]"></app-vault-icon>
</td>
<td <td
bitCell
class="tw-cursor-pointer" class="tw-cursor-pointer"
[ngClass]="{ 'tw-bg-primary-100': isDrawerIsOpenForThisRecord(row.applicationName) }" [ngClass]="{ 'tw-bg-primary-100': isDrawerIsOpenForThisRecord(row.applicationName) }"
(click)="showAppAtRiskMembers(row.applicationName)" (click)="showAppAtRiskMembers(row.applicationName)"
(keypress)="showAppAtRiskMembers(row.applicationName)" (keydown.enter)="showAppAtRiskMembers(row.applicationName)"
(keydown.space)="showAppAtRiskMembers(row.applicationName)"
role="button"
tabindex="0"
[attr.aria-label]="'viewItem' | i18n"
>
<app-vault-icon *ngIf="row.ciphers.length > 0" [cipher]="row.ciphers[0]"></app-vault-icon>
</td>
<td
bitCell bitCell
class="tw-cursor-pointer"
[ngClass]="{ 'tw-bg-primary-100': isDrawerIsOpenForThisRecord(row.applicationName) }"
(click)="showAppAtRiskMembers(row.applicationName)"
(keydown.enter)="showAppAtRiskMembers(row.applicationName)"
(keydown.space)="showAppAtRiskMembers(row.applicationName)"
role="button"
tabindex="0"
[attr.aria-label]="'viewItem' | i18n"
> >
<span>{{ row.applicationName }}</span> <span>{{ row.applicationName }}</span>
</td> </td>
<td <td
bitCell bitCell
class="tw-cursor-pointer"
[ngClass]="{ 'tw-bg-primary-100': isDrawerIsOpenForThisRecord(row.applicationName) }" [ngClass]="{ 'tw-bg-primary-100': isDrawerIsOpenForThisRecord(row.applicationName) }"
(click)="showAppAtRiskMembers(row.applicationName)"
(keydown.enter)="showAppAtRiskMembers(row.applicationName)"
(keydown.space)="showAppAtRiskMembers(row.applicationName)"
role="button"
tabindex="0"
[attr.aria-label]="'viewItem' | i18n"
> >
<span> <span>
{{ row.atRiskPasswordCount }} {{ row.atRiskPasswordCount }}
@@ -53,7 +77,14 @@
</td> </td>
<td <td
bitCell bitCell
class="tw-cursor-pointer"
[ngClass]="{ 'tw-bg-primary-100': isDrawerIsOpenForThisRecord(row.applicationName) }" [ngClass]="{ 'tw-bg-primary-100': isDrawerIsOpenForThisRecord(row.applicationName) }"
(click)="showAppAtRiskMembers(row.applicationName)"
(keydown.enter)="showAppAtRiskMembers(row.applicationName)"
(keydown.space)="showAppAtRiskMembers(row.applicationName)"
role="button"
tabindex="0"
[attr.aria-label]="'viewItem' | i18n"
> >
<span> <span>
{{ row.passwordCount }} {{ row.passwordCount }}
@@ -61,7 +92,14 @@
</td> </td>
<td <td
bitCell bitCell
class="tw-cursor-pointer"
[ngClass]="{ 'tw-bg-primary-100': isDrawerIsOpenForThisRecord(row.applicationName) }" [ngClass]="{ 'tw-bg-primary-100': isDrawerIsOpenForThisRecord(row.applicationName) }"
(click)="showAppAtRiskMembers(row.applicationName)"
(keydown.enter)="showAppAtRiskMembers(row.applicationName)"
(keydown.space)="showAppAtRiskMembers(row.applicationName)"
role="button"
tabindex="0"
[attr.aria-label]="'viewItem' | i18n"
> >
<span> <span>
{{ row.atRiskMemberCount }} {{ row.atRiskMemberCount }}
@@ -70,7 +108,14 @@
<td <td
bitCell bitCell
data-testid="total-membership" data-testid="total-membership"
class="tw-cursor-pointer"
[ngClass]="{ 'tw-bg-primary-100': isDrawerIsOpenForThisRecord(row.applicationName) }" [ngClass]="{ 'tw-bg-primary-100': isDrawerIsOpenForThisRecord(row.applicationName) }"
(click)="showAppAtRiskMembers(row.applicationName)"
(keydown.enter)="showAppAtRiskMembers(row.applicationName)"
(keydown.space)="showAppAtRiskMembers(row.applicationName)"
role="button"
tabindex="0"
[attr.aria-label]="'viewItem' | i18n"
> >
{{ row.memberCount }} {{ row.memberCount }}
</td> </td>
@@ -78,6 +123,7 @@
bitCell bitCell
*ngIf="showRowMenuForCriticalApps" *ngIf="showRowMenuForCriticalApps"
[ngClass]="{ 'tw-bg-primary-100': isDrawerIsOpenForThisRecord(row.applicationName) }" [ngClass]="{ 'tw-bg-primary-100': isDrawerIsOpenForThisRecord(row.applicationName) }"
appStopProp
> >
<button <button
[bitMenuTriggerFor]="rowMenu" [bitMenuTriggerFor]="rowMenu"