mirror of
https://github.com/bitwarden/browser
synced 2025-12-11 13:53:34 +00:00
Feature/password protected export (#612)
* Add password protected export * Run prettier * Test password protected export service * Create type for known import type strings * Test import service changes * Test bitwarden password importer * Run prettier * Remove unnecessary class properties * Run prettier * Tslint fixes * Add KdfType to password protected export * Linter fixes * run prettier
This commit is contained in:
@@ -2,6 +2,11 @@ import { EventView } from "../models/view/eventView";
|
|||||||
|
|
||||||
export abstract class ExportService {
|
export abstract class ExportService {
|
||||||
getExport: (format?: "csv" | "json" | "encrypted_json") => Promise<string>;
|
getExport: (format?: "csv" | "json" | "encrypted_json") => Promise<string>;
|
||||||
|
getPasswordProtectedExport: (
|
||||||
|
password: string,
|
||||||
|
format?: "csv" | "json" | "encrypted_json",
|
||||||
|
organizationId?: string
|
||||||
|
) => Promise<string>;
|
||||||
getOrganizationExport: (
|
getOrganizationExport: (
|
||||||
organizationId: string,
|
organizationId: string,
|
||||||
format?: "csv" | "json" | "encrypted_json"
|
format?: "csv" | "json" | "encrypted_json"
|
||||||
|
|||||||
@@ -1,13 +1,14 @@
|
|||||||
import { Importer } from "../importers/importer";
|
import { Importer } from "../importers/importer";
|
||||||
|
import { ImportType } from "../services/import.service";
|
||||||
|
|
||||||
export interface ImportOption {
|
export interface ImportOption {
|
||||||
id: string;
|
id: string;
|
||||||
name: string;
|
name: string;
|
||||||
}
|
}
|
||||||
export abstract class ImportService {
|
export abstract class ImportService {
|
||||||
featuredImportOptions: ImportOption[];
|
featuredImportOptions: readonly ImportOption[];
|
||||||
regularImportOptions: ImportOption[];
|
regularImportOptions: readonly ImportOption[];
|
||||||
getImportOptions: () => ImportOption[];
|
getImportOptions: () => ImportOption[];
|
||||||
import: (importer: Importer, fileContents: string, organizationId?: string) => Promise<Error>;
|
import: (importer: Importer, fileContents: string, organizationId?: string) => Promise<Error>;
|
||||||
getImporter: (format: string, organizationId: string) => Importer;
|
getImporter: (format: ImportType, organizationId: string, password?: string) => Importer;
|
||||||
}
|
}
|
||||||
|
|||||||
101
common/src/importers/bitwardenPasswordProtectedImporter.ts
Normal file
101
common/src/importers/bitwardenPasswordProtectedImporter.ts
Normal file
@@ -0,0 +1,101 @@
|
|||||||
|
import { BaseImporter } from "./baseImporter";
|
||||||
|
import { Importer } from "./importer";
|
||||||
|
|
||||||
|
import { EncString } from "../models/domain/encString";
|
||||||
|
import { ImportResult } from "../models/domain/importResult";
|
||||||
|
|
||||||
|
import { CryptoService } from "../abstractions/crypto.service";
|
||||||
|
import { I18nService } from "../abstractions/i18n.service";
|
||||||
|
import { ImportService } from "../abstractions/import.service";
|
||||||
|
import { KdfType } from "../enums/kdfType";
|
||||||
|
import { SymmetricCryptoKey } from "../models/domain/symmetricCryptoKey";
|
||||||
|
|
||||||
|
class BitwardenPasswordProtectedFileFormat {
|
||||||
|
encrypted: boolean;
|
||||||
|
passwordProtected: boolean;
|
||||||
|
format: "json" | "csv" | "encrypted_json";
|
||||||
|
salt: string;
|
||||||
|
kdfIterations: number;
|
||||||
|
kdfType: number;
|
||||||
|
// tslint:disable-next-line
|
||||||
|
encKeyValidation_DO_NOT_EDIT: string;
|
||||||
|
data: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
export class BitwardenPasswordProtectedImporter extends BaseImporter implements Importer {
|
||||||
|
private innerImporter: Importer;
|
||||||
|
private key: SymmetricCryptoKey;
|
||||||
|
|
||||||
|
constructor(
|
||||||
|
private importService: ImportService,
|
||||||
|
private cryptoService: CryptoService,
|
||||||
|
private i18nService: I18nService,
|
||||||
|
private password: string
|
||||||
|
) {
|
||||||
|
super();
|
||||||
|
}
|
||||||
|
|
||||||
|
async parse(data: string): Promise<ImportResult> {
|
||||||
|
const result = new ImportResult();
|
||||||
|
const parsedData = JSON.parse(data);
|
||||||
|
if (this.cannotParseFile(parsedData)) {
|
||||||
|
result.success = false;
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
|
||||||
|
this.setInnerImporter(parsedData.format);
|
||||||
|
|
||||||
|
if (!(await this.checkPassword(parsedData))) {
|
||||||
|
result.success = false;
|
||||||
|
result.errorMessage = this.i18nService.t("importEncKeyError");
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
|
||||||
|
const encData = new EncString(parsedData.data);
|
||||||
|
const clearTextData = await this.cryptoService.decryptToUtf8(encData, this.key);
|
||||||
|
return this.innerImporter.parse(clearTextData);
|
||||||
|
}
|
||||||
|
|
||||||
|
private async checkPassword(jdoc: BitwardenPasswordProtectedFileFormat): Promise<boolean> {
|
||||||
|
this.key = await this.cryptoService.makePinKey(
|
||||||
|
this.password,
|
||||||
|
jdoc.salt,
|
||||||
|
KdfType.PBKDF2_SHA256,
|
||||||
|
jdoc.kdfIterations
|
||||||
|
);
|
||||||
|
|
||||||
|
const encKeyValidation = new EncString(jdoc.encKeyValidation_DO_NOT_EDIT);
|
||||||
|
|
||||||
|
const encKeyValidationDecrypt = await this.cryptoService.decryptToUtf8(
|
||||||
|
encKeyValidation,
|
||||||
|
this.key
|
||||||
|
);
|
||||||
|
if (encKeyValidationDecrypt === null) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
private cannotParseFile(jdoc: BitwardenPasswordProtectedFileFormat): boolean {
|
||||||
|
return (
|
||||||
|
!jdoc ||
|
||||||
|
!jdoc.encrypted ||
|
||||||
|
!jdoc.passwordProtected ||
|
||||||
|
!(jdoc.format === "csv" || jdoc.format === "json" || jdoc.format === "encrypted_json") ||
|
||||||
|
!jdoc.salt ||
|
||||||
|
!jdoc.kdfIterations ||
|
||||||
|
typeof jdoc.kdfIterations !== "number" ||
|
||||||
|
jdoc.kdfType == null ||
|
||||||
|
KdfType[jdoc.kdfType] == null ||
|
||||||
|
!jdoc.encKeyValidation_DO_NOT_EDIT ||
|
||||||
|
!jdoc.data
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
private setInnerImporter(format: "csv" | "json" | "encrypted_json") {
|
||||||
|
this.innerImporter =
|
||||||
|
format === "csv"
|
||||||
|
? this.importService.getImporter("bitwardencsv", this.organizationId)
|
||||||
|
: this.importService.getImporter("bitwardenjson", this.organizationId);
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -1,10 +1,12 @@
|
|||||||
import * as papa from "papaparse";
|
import * as papa from "papaparse";
|
||||||
|
|
||||||
import { CipherType } from "../enums/cipherType";
|
import { CipherType } from "../enums/cipherType";
|
||||||
|
import { KdfType } from "../enums/kdfType";
|
||||||
|
|
||||||
import { ApiService } from "../abstractions/api.service";
|
import { ApiService } from "../abstractions/api.service";
|
||||||
import { CipherService } from "../abstractions/cipher.service";
|
import { CipherService } from "../abstractions/cipher.service";
|
||||||
import { CryptoService } from "../abstractions/crypto.service";
|
import { CryptoService } from "../abstractions/crypto.service";
|
||||||
|
import { CryptoFunctionService } from "../abstractions/cryptoFunction.service";
|
||||||
import { ExportService as ExportServiceAbstraction } from "../abstractions/export.service";
|
import { ExportService as ExportServiceAbstraction } from "../abstractions/export.service";
|
||||||
import { FolderService } from "../abstractions/folder.service";
|
import { FolderService } from "../abstractions/folder.service";
|
||||||
|
|
||||||
@@ -33,7 +35,8 @@ export class ExportService implements ExportServiceAbstraction {
|
|||||||
private folderService: FolderService,
|
private folderService: FolderService,
|
||||||
private cipherService: CipherService,
|
private cipherService: CipherService,
|
||||||
private apiService: ApiService,
|
private apiService: ApiService,
|
||||||
private cryptoService: CryptoService
|
private cryptoService: CryptoService,
|
||||||
|
private cryptoFunctionService: CryptoFunctionService
|
||||||
) {}
|
) {}
|
||||||
|
|
||||||
async getExport(format: "csv" | "json" | "encrypted_json" = "csv"): Promise<string> {
|
async getExport(format: "csv" | "json" | "encrypted_json" = "csv"): Promise<string> {
|
||||||
@@ -44,6 +47,41 @@ export class ExportService implements ExportServiceAbstraction {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async getPasswordProtectedExport(
|
||||||
|
password: string,
|
||||||
|
format: "csv" | "json" | "encrypted_json" = "csv",
|
||||||
|
organizationId?: string
|
||||||
|
): Promise<string> {
|
||||||
|
const clearText = organizationId
|
||||||
|
? await this.getOrganizationExport(organizationId, format)
|
||||||
|
: await this.getExport(format);
|
||||||
|
|
||||||
|
const salt = Utils.fromBufferToB64(await this.cryptoFunctionService.randomBytes(16));
|
||||||
|
const kdfIterations = 100000;
|
||||||
|
const key = await this.cryptoService.makePinKey(
|
||||||
|
password,
|
||||||
|
salt,
|
||||||
|
KdfType.PBKDF2_SHA256,
|
||||||
|
kdfIterations
|
||||||
|
);
|
||||||
|
|
||||||
|
const encKeyValidation = await this.cryptoService.encrypt(Utils.newGuid(), key);
|
||||||
|
const encText = await this.cryptoService.encrypt(clearText, key);
|
||||||
|
|
||||||
|
const jsonDoc: any = {
|
||||||
|
encrypted: true,
|
||||||
|
passwordProtected: true,
|
||||||
|
format: format,
|
||||||
|
salt: salt,
|
||||||
|
kdfIterations: kdfIterations,
|
||||||
|
kdfType: KdfType.PBKDF2_SHA256,
|
||||||
|
encKeyValidation_DO_NOT_EDIT: encKeyValidation.encryptedString,
|
||||||
|
data: encText.encryptedString,
|
||||||
|
};
|
||||||
|
|
||||||
|
return JSON.stringify(jsonDoc, null, " ");
|
||||||
|
}
|
||||||
|
|
||||||
async getOrganizationExport(
|
async getOrganizationExport(
|
||||||
organizationId: string,
|
organizationId: string,
|
||||||
format: "csv" | "json" | "encrypted_json" = "csv"
|
format: "csv" | "json" | "encrypted_json" = "csv"
|
||||||
|
|||||||
@@ -32,6 +32,7 @@ import { AvastJsonImporter } from "../importers/avastJsonImporter";
|
|||||||
import { AviraCsvImporter } from "../importers/aviraCsvImporter";
|
import { AviraCsvImporter } from "../importers/aviraCsvImporter";
|
||||||
import { BitwardenCsvImporter } from "../importers/bitwardenCsvImporter";
|
import { BitwardenCsvImporter } from "../importers/bitwardenCsvImporter";
|
||||||
import { BitwardenJsonImporter } from "../importers/bitwardenJsonImporter";
|
import { BitwardenJsonImporter } from "../importers/bitwardenJsonImporter";
|
||||||
|
import { BitwardenPasswordProtectedImporter } from "../importers/bitwardenPasswordProtectedImporter";
|
||||||
import { BlackBerryCsvImporter } from "../importers/blackBerryCsvImporter";
|
import { BlackBerryCsvImporter } from "../importers/blackBerryCsvImporter";
|
||||||
import { BlurCsvImporter } from "../importers/blurCsvImporter";
|
import { BlurCsvImporter } from "../importers/blurCsvImporter";
|
||||||
import { ButtercupCsvImporter } from "../importers/buttercupCsvImporter";
|
import { ButtercupCsvImporter } from "../importers/buttercupCsvImporter";
|
||||||
@@ -82,8 +83,7 @@ import { UpmCsvImporter } from "../importers/upmCsvImporter";
|
|||||||
import { YotiCsvImporter } from "../importers/yotiCsvImporter";
|
import { YotiCsvImporter } from "../importers/yotiCsvImporter";
|
||||||
import { ZohoVaultCsvImporter } from "../importers/zohoVaultCsvImporter";
|
import { ZohoVaultCsvImporter } from "../importers/zohoVaultCsvImporter";
|
||||||
|
|
||||||
export class ImportService implements ImportServiceAbstraction {
|
const featuredImportOptions = [
|
||||||
featuredImportOptions = [
|
|
||||||
{ id: "bitwardenjson", name: "Bitwarden (json)" },
|
{ id: "bitwardenjson", name: "Bitwarden (json)" },
|
||||||
{ id: "bitwardencsv", name: "Bitwarden (csv)" },
|
{ id: "bitwardencsv", name: "Bitwarden (csv)" },
|
||||||
{ id: "chromecsv", name: "Chrome (csv)" },
|
{ id: "chromecsv", name: "Chrome (csv)" },
|
||||||
@@ -93,9 +93,9 @@ export class ImportService implements ImportServiceAbstraction {
|
|||||||
{ id: "lastpasscsv", name: "LastPass (csv)" },
|
{ id: "lastpasscsv", name: "LastPass (csv)" },
|
||||||
{ id: "safaricsv", name: "Safari and macOS (csv)" },
|
{ id: "safaricsv", name: "Safari and macOS (csv)" },
|
||||||
{ id: "1password1pif", name: "1Password (1pif)" },
|
{ id: "1password1pif", name: "1Password (1pif)" },
|
||||||
];
|
] as const;
|
||||||
|
|
||||||
regularImportOptions: ImportOption[] = [
|
const regularImportOptions = [
|
||||||
{ id: "keepassxcsv", name: "KeePassX (csv)" },
|
{ id: "keepassxcsv", name: "KeePassX (csv)" },
|
||||||
{ id: "1passwordwincsv", name: "1Password 6 and 7 Windows (csv)" },
|
{ id: "1passwordwincsv", name: "1Password 6 and 7 Windows (csv)" },
|
||||||
{ id: "1passwordmaccsv", name: "1Password 6 and 7 Mac (csv)" },
|
{ id: "1passwordmaccsv", name: "1Password 6 and 7 Mac (csv)" },
|
||||||
@@ -145,7 +145,17 @@ export class ImportService implements ImportServiceAbstraction {
|
|||||||
{ id: "encryptrcsv", name: "Encryptr (csv)" },
|
{ id: "encryptrcsv", name: "Encryptr (csv)" },
|
||||||
{ id: "yoticsv", name: "Yoti (csv)" },
|
{ id: "yoticsv", name: "Yoti (csv)" },
|
||||||
{ id: "nordpasscsv", name: "Nordpass (csv)" },
|
{ id: "nordpasscsv", name: "Nordpass (csv)" },
|
||||||
];
|
] as const;
|
||||||
|
|
||||||
|
export type ImportType =
|
||||||
|
| typeof featuredImportOptions[number]["id"]
|
||||||
|
| typeof regularImportOptions[number]["id"]
|
||||||
|
| "bitwardenpasswordprotected";
|
||||||
|
|
||||||
|
export class ImportService implements ImportServiceAbstraction {
|
||||||
|
featuredImportOptions = featuredImportOptions as readonly ImportOption[];
|
||||||
|
|
||||||
|
regularImportOptions = regularImportOptions as readonly ImportOption[];
|
||||||
|
|
||||||
constructor(
|
constructor(
|
||||||
private cipherService: CipherService,
|
private cipherService: CipherService,
|
||||||
@@ -198,8 +208,12 @@ export class ImportService implements ImportServiceAbstraction {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
getImporter(format: string, organizationId: string = null): Importer {
|
getImporter(
|
||||||
const importer = this.getImporterInstance(format);
|
format: ImportType,
|
||||||
|
organizationId: string = null,
|
||||||
|
password: string = null
|
||||||
|
): Importer {
|
||||||
|
const importer = this.getImporterInstance(format, password);
|
||||||
if (importer == null) {
|
if (importer == null) {
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
@@ -207,8 +221,8 @@ export class ImportService implements ImportServiceAbstraction {
|
|||||||
return importer;
|
return importer;
|
||||||
}
|
}
|
||||||
|
|
||||||
private getImporterInstance(format: string) {
|
private getImporterInstance(format: ImportType, password: string) {
|
||||||
if (format == null || format === "") {
|
if (format == null) {
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -217,6 +231,13 @@ export class ImportService implements ImportServiceAbstraction {
|
|||||||
return new BitwardenCsvImporter();
|
return new BitwardenCsvImporter();
|
||||||
case "bitwardenjson":
|
case "bitwardenjson":
|
||||||
return new BitwardenJsonImporter(this.cryptoService, this.i18nService);
|
return new BitwardenJsonImporter(this.cryptoService, this.i18nService);
|
||||||
|
case "bitwardenpasswordprotected":
|
||||||
|
return new BitwardenPasswordProtectedImporter(
|
||||||
|
this,
|
||||||
|
this.cryptoService,
|
||||||
|
this.i18nService,
|
||||||
|
password
|
||||||
|
);
|
||||||
case "lastpasscsv":
|
case "lastpasscsv":
|
||||||
case "passboltcsv":
|
case "passboltcsv":
|
||||||
return new LastPassCsvImporter();
|
return new LastPassCsvImporter();
|
||||||
@@ -254,8 +275,8 @@ export class ImportService implements ImportServiceAbstraction {
|
|||||||
return new OnePasswordMacCsvImporter();
|
return new OnePasswordMacCsvImporter();
|
||||||
case "keepercsv":
|
case "keepercsv":
|
||||||
return new KeeperCsvImporter();
|
return new KeeperCsvImporter();
|
||||||
case "keeperjson":
|
// case "keeperjson":
|
||||||
return new KeeperJsonImporter();
|
// return new KeeperJsonImporter();
|
||||||
case "passworddragonxml":
|
case "passworddragonxml":
|
||||||
return new PasswordDragonXmlImporter();
|
return new PasswordDragonXmlImporter();
|
||||||
case "enpasscsv":
|
case "enpasscsv":
|
||||||
|
|||||||
203
spec/common/importers/bitwardenPasswordProtectedImporter.spec.ts
Normal file
203
spec/common/importers/bitwardenPasswordProtectedImporter.spec.ts
Normal file
@@ -0,0 +1,203 @@
|
|||||||
|
import Substitute, { Arg, SubstituteOf } from "@fluffy-spoon/substitute";
|
||||||
|
|
||||||
|
import { CryptoService } from "jslib-common/abstractions/crypto.service";
|
||||||
|
import { I18nService } from "jslib-common/abstractions/i18n.service";
|
||||||
|
import { ImportService } from "jslib-common/abstractions/import.service";
|
||||||
|
|
||||||
|
import { KdfType } from "jslib-common/enums/kdfType";
|
||||||
|
|
||||||
|
import { BitwardenPasswordProtectedImporter } from "jslib-common/importers/bitwardenPasswordProtectedImporter";
|
||||||
|
import { Importer } from "jslib-common/importers/importer";
|
||||||
|
|
||||||
|
import { Utils } from "jslib-common/misc/utils";
|
||||||
|
import { ImportResult } from "jslib-common/models/domain/importResult";
|
||||||
|
|
||||||
|
describe("BitwardenPasswordProtectedImporter", () => {
|
||||||
|
let importer: BitwardenPasswordProtectedImporter;
|
||||||
|
let innerImporter: SubstituteOf<Importer>;
|
||||||
|
let importService: SubstituteOf<ImportService>;
|
||||||
|
let cryptoService: SubstituteOf<CryptoService>;
|
||||||
|
let i18nService: SubstituteOf<I18nService>;
|
||||||
|
const password = Utils.newGuid();
|
||||||
|
const result = new ImportResult();
|
||||||
|
let jDoc: {
|
||||||
|
encrypted?: boolean;
|
||||||
|
passwordProtected?: boolean;
|
||||||
|
format?: string;
|
||||||
|
salt?: string;
|
||||||
|
kdfIterations?: any;
|
||||||
|
kdfType?: any;
|
||||||
|
encKeyValidation_DO_NOT_EDIT?: string;
|
||||||
|
data?: string;
|
||||||
|
};
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
cryptoService = Substitute.for<CryptoService>();
|
||||||
|
i18nService = Substitute.for<I18nService>();
|
||||||
|
importService = Substitute.for<ImportService>();
|
||||||
|
innerImporter = Substitute.for<Importer>();
|
||||||
|
|
||||||
|
jDoc = {
|
||||||
|
encrypted: true,
|
||||||
|
passwordProtected: true,
|
||||||
|
format: "csv",
|
||||||
|
salt: "c2FsdA==",
|
||||||
|
kdfIterations: 100000,
|
||||||
|
kdfType: KdfType.PBKDF2_SHA256,
|
||||||
|
encKeyValidation_DO_NOT_EDIT: Utils.newGuid(),
|
||||||
|
data: Utils.newGuid(),
|
||||||
|
};
|
||||||
|
|
||||||
|
result.success = true;
|
||||||
|
innerImporter.parse(Arg.any()).resolves(result);
|
||||||
|
importer = new BitwardenPasswordProtectedImporter(
|
||||||
|
importService,
|
||||||
|
cryptoService,
|
||||||
|
i18nService,
|
||||||
|
password
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("Required Json Data", () => {
|
||||||
|
it("succeeds with default jdoc", async () => {
|
||||||
|
cryptoService.decryptToUtf8(Arg.any(), Arg.any()).resolves("successful decryption");
|
||||||
|
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("accepts json format", async () => {
|
||||||
|
jDoc.format = "json";
|
||||||
|
cryptoService.decryptToUtf8(Arg.any(), Arg.any()).resolves("successful decryption");
|
||||||
|
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("accepts encrypted_json format", async () => {
|
||||||
|
jDoc.format = "encrypted_json";
|
||||||
|
cryptoService.decryptToUtf8(Arg.any(), Arg.any()).resolves("successful decryption");
|
||||||
|
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("fails if encrypted === false", async () => {
|
||||||
|
jDoc.encrypted = false;
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("fails if encrypted === null", async () => {
|
||||||
|
jDoc.encrypted = null;
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("fails if passwordProtected === false", async () => {
|
||||||
|
jDoc.passwordProtected = false;
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("fails if passwordProtected === null", async () => {
|
||||||
|
jDoc.passwordProtected = null;
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("fails if format === null", async () => {
|
||||||
|
jDoc.format = null;
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("fails if format not known", async () => {
|
||||||
|
jDoc.format = "Not a real format";
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("fails if salt === null", async () => {
|
||||||
|
jDoc.salt = null;
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("fails if kdfIterations === null", async () => {
|
||||||
|
jDoc.kdfIterations = null;
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("fails if kdfIterations is not a number", async () => {
|
||||||
|
jDoc.kdfIterations = "not a number";
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("fails if kdfType === null", async () => {
|
||||||
|
jDoc.kdfType = null;
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("fails if kdfType is not a string", async () => {
|
||||||
|
jDoc.kdfType = "not a valid kdf type";
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("fails if kdfType is not a known kdfType", async () => {
|
||||||
|
jDoc.kdfType = -1;
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("fails if encKeyValidation_DO_NOT_EDIT === null", async () => {
|
||||||
|
jDoc.encKeyValidation_DO_NOT_EDIT = null;
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("fails if data === null", async () => {
|
||||||
|
jDoc.data = null;
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(false);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("inner importer", () => {
|
||||||
|
beforeEach(() => {
|
||||||
|
cryptoService.decryptToUtf8(Arg.any(), Arg.any()).resolves("successful decryption");
|
||||||
|
});
|
||||||
|
it("delegates success", async () => {
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(true);
|
||||||
|
result.success = false;
|
||||||
|
expect((await importer.parse(JSON.stringify(jDoc))).success).toEqual(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("passes on organization Id", async () => {
|
||||||
|
jDoc.format = "csv";
|
||||||
|
importer.organizationId = Utils.newGuid();
|
||||||
|
await importer.parse(JSON.stringify(jDoc));
|
||||||
|
|
||||||
|
importService.received(1).getImporter("bitwardencsv", importer.organizationId);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("passes null organizationId if none set", async () => {
|
||||||
|
jDoc.format = "csv";
|
||||||
|
importer.organizationId = null;
|
||||||
|
await importer.parse(JSON.stringify(jDoc));
|
||||||
|
|
||||||
|
importService.received(1).getImporter("bitwardencsv", null);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("gets csv importer for csv format", async () => {
|
||||||
|
jDoc.format = "csv";
|
||||||
|
|
||||||
|
await importer.parse(JSON.stringify(jDoc));
|
||||||
|
|
||||||
|
importService.received(1).getImporter("bitwardencsv", Arg.any());
|
||||||
|
});
|
||||||
|
|
||||||
|
it("gets json importer for json format", async () => {
|
||||||
|
jDoc.format = "json";
|
||||||
|
|
||||||
|
await importer.parse(JSON.stringify(jDoc));
|
||||||
|
|
||||||
|
importService.received(1).getImporter("bitwardenjson", Arg.any());
|
||||||
|
});
|
||||||
|
|
||||||
|
it("gets json importer for encrypted_json format", async () => {
|
||||||
|
jDoc.format = "encrypted_json";
|
||||||
|
|
||||||
|
await importer.parse(JSON.stringify(jDoc));
|
||||||
|
|
||||||
|
importService.received(1).getImporter("bitwardenjson", Arg.any());
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -1,8 +1,9 @@
|
|||||||
import { Substitute, SubstituteOf } from "@fluffy-spoon/substitute";
|
import { Arg, Substitute, SubstituteOf } from "@fluffy-spoon/substitute";
|
||||||
|
|
||||||
import { ApiService } from "jslib-common/abstractions/api.service";
|
import { ApiService } from "jslib-common/abstractions/api.service";
|
||||||
import { CipherService } from "jslib-common/abstractions/cipher.service";
|
import { CipherService } from "jslib-common/abstractions/cipher.service";
|
||||||
import { CryptoService } from "jslib-common/abstractions/crypto.service";
|
import { CryptoService } from "jslib-common/abstractions/crypto.service";
|
||||||
|
import { CryptoFunctionService } from "jslib-common/abstractions/cryptoFunction.service";
|
||||||
import { FolderService } from "jslib-common/abstractions/folder.service";
|
import { FolderService } from "jslib-common/abstractions/folder.service";
|
||||||
|
|
||||||
import { ExportService } from "jslib-common/services/export.service";
|
import { ExportService } from "jslib-common/services/export.service";
|
||||||
@@ -13,6 +14,9 @@ import { Login } from "jslib-common/models/domain/login";
|
|||||||
import { CipherWithIds as CipherExport } from "jslib-common/models/export/cipherWithIds";
|
import { CipherWithIds as CipherExport } from "jslib-common/models/export/cipherWithIds";
|
||||||
|
|
||||||
import { CipherType } from "jslib-common/enums/cipherType";
|
import { CipherType } from "jslib-common/enums/cipherType";
|
||||||
|
import { KdfType } from "jslib-common/enums/kdfType";
|
||||||
|
|
||||||
|
import { Utils } from "jslib-common/misc/utils";
|
||||||
import { CipherView } from "jslib-common/models/view/cipherView";
|
import { CipherView } from "jslib-common/models/view/cipherView";
|
||||||
import { LoginView } from "jslib-common/models/view/loginView";
|
import { LoginView } from "jslib-common/models/view/loginView";
|
||||||
|
|
||||||
@@ -85,12 +89,14 @@ function expectEqualCiphers(ciphers: CipherView[] | Cipher[], jsonResult: string
|
|||||||
describe("ExportService", () => {
|
describe("ExportService", () => {
|
||||||
let exportService: ExportService;
|
let exportService: ExportService;
|
||||||
let apiService: SubstituteOf<ApiService>;
|
let apiService: SubstituteOf<ApiService>;
|
||||||
|
let cryptoFunctionService: SubstituteOf<CryptoFunctionService>;
|
||||||
let cipherService: SubstituteOf<CipherService>;
|
let cipherService: SubstituteOf<CipherService>;
|
||||||
let folderService: SubstituteOf<FolderService>;
|
let folderService: SubstituteOf<FolderService>;
|
||||||
let cryptoService: SubstituteOf<CryptoService>;
|
let cryptoService: SubstituteOf<CryptoService>;
|
||||||
|
|
||||||
beforeEach(() => {
|
beforeEach(() => {
|
||||||
apiService = Substitute.for<ApiService>();
|
apiService = Substitute.for<ApiService>();
|
||||||
|
cryptoFunctionService = Substitute.for<CryptoFunctionService>();
|
||||||
cipherService = Substitute.for<CipherService>();
|
cipherService = Substitute.for<CipherService>();
|
||||||
folderService = Substitute.for<FolderService>();
|
folderService = Substitute.for<FolderService>();
|
||||||
cryptoService = Substitute.for<CryptoService>();
|
cryptoService = Substitute.for<CryptoService>();
|
||||||
@@ -98,7 +104,13 @@ describe("ExportService", () => {
|
|||||||
folderService.getAllDecrypted().resolves([]);
|
folderService.getAllDecrypted().resolves([]);
|
||||||
folderService.getAll().resolves([]);
|
folderService.getAll().resolves([]);
|
||||||
|
|
||||||
exportService = new ExportService(folderService, cipherService, apiService, cryptoService);
|
exportService = new ExportService(
|
||||||
|
folderService,
|
||||||
|
cipherService,
|
||||||
|
apiService,
|
||||||
|
cryptoService,
|
||||||
|
cryptoFunctionService
|
||||||
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
it("exports unecrypted user ciphers", async () => {
|
it("exports unecrypted user ciphers", async () => {
|
||||||
@@ -132,4 +144,68 @@ describe("ExportService", () => {
|
|||||||
|
|
||||||
expectEqualCiphers(UserCipherDomains.slice(0, 2), actual);
|
expectEqualCiphers(UserCipherDomains.slice(0, 2), actual);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe("password protected export", () => {
|
||||||
|
let exportString: string;
|
||||||
|
let exportObject: any;
|
||||||
|
let mac: SubstituteOf<EncString>;
|
||||||
|
let data: SubstituteOf<EncString>;
|
||||||
|
const password = "password";
|
||||||
|
const salt = "salt";
|
||||||
|
|
||||||
|
describe("export json object", () => {
|
||||||
|
beforeEach(async () => {
|
||||||
|
mac = Substitute.for<EncString>();
|
||||||
|
data = Substitute.for<EncString>();
|
||||||
|
|
||||||
|
mac.encryptedString = "mac";
|
||||||
|
data.encryptedString = "encData";
|
||||||
|
|
||||||
|
spyOn(Utils, "fromBufferToB64").and.returnValue(salt);
|
||||||
|
cipherService.getAllDecrypted().resolves(UserCipherViews.slice(0, 1));
|
||||||
|
|
||||||
|
exportString = await exportService.getPasswordProtectedExport(password);
|
||||||
|
exportObject = JSON.parse(exportString);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("specifies it is encrypted", () => {
|
||||||
|
expect(exportObject.encrypted).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("specifies it's password protected", () => {
|
||||||
|
expect(exportObject.passwordProtected).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("specifies format", () => {
|
||||||
|
expect(exportObject).toEqual(jasmine.objectContaining({ format: jasmine.any(String) }));
|
||||||
|
});
|
||||||
|
|
||||||
|
it("specifies salt", () => {
|
||||||
|
expect(exportObject.salt).toEqual("salt");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("specifies kdfIterations", () => {
|
||||||
|
expect(exportObject.kdfIterations).toEqual(100000);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("has kdfType", () => {
|
||||||
|
expect(exportObject.kdfType).toEqual(KdfType.PBKDF2_SHA256);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("has a mac property", () => {
|
||||||
|
cryptoService.encrypt(Arg.any(), Arg.any()).resolves(mac);
|
||||||
|
expect(exportObject.encKeyValidation_DO_NOT_EDIT).toEqual(mac.encryptedString);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("has data property", () => {
|
||||||
|
cryptoService.encrypt(Arg.any(), Arg.any()).resolves(data);
|
||||||
|
expect(exportObject.data).toEqual(data.encryptedString);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("encrypts the data property", async () => {
|
||||||
|
const unencrypted = await exportService.getExport();
|
||||||
|
expect(exportObject.data).not.toEqual(unencrypted);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
74
spec/common/services/import.service.spec.ts
Normal file
74
spec/common/services/import.service.spec.ts
Normal file
@@ -0,0 +1,74 @@
|
|||||||
|
import Substitute, { Arg, SubstituteOf } from "@fluffy-spoon/substitute";
|
||||||
|
import { ApiService } from "jslib-common/abstractions/api.service";
|
||||||
|
|
||||||
|
import { CipherService } from "jslib-common/abstractions/cipher.service";
|
||||||
|
import { CollectionService } from "jslib-common/abstractions/collection.service";
|
||||||
|
import { CryptoService } from "jslib-common/abstractions/crypto.service";
|
||||||
|
import { FolderService } from "jslib-common/abstractions/folder.service";
|
||||||
|
import { I18nService } from "jslib-common/abstractions/i18n.service";
|
||||||
|
import { PlatformUtilsService } from "jslib-common/abstractions/platformUtils.service";
|
||||||
|
import { BitwardenPasswordProtectedImporter } from "jslib-common/importers/bitwardenPasswordProtectedImporter";
|
||||||
|
|
||||||
|
import { Importer } from "jslib-common/importers/importer";
|
||||||
|
import { Utils } from "jslib-common/misc/utils";
|
||||||
|
|
||||||
|
import { ImportService } from "jslib-common/services/import.service";
|
||||||
|
|
||||||
|
describe("ImportService", () => {
|
||||||
|
let importService: ImportService;
|
||||||
|
let cipherService: SubstituteOf<CipherService>;
|
||||||
|
let folderService: SubstituteOf<FolderService>;
|
||||||
|
let apiService: SubstituteOf<ApiService>;
|
||||||
|
let i18nService: SubstituteOf<I18nService>;
|
||||||
|
let collectionService: SubstituteOf<CollectionService>;
|
||||||
|
let platformUtilsService: SubstituteOf<PlatformUtilsService>;
|
||||||
|
let cryptoService: SubstituteOf<CryptoService>;
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
cipherService = Substitute.for<CipherService>();
|
||||||
|
folderService = Substitute.for<FolderService>();
|
||||||
|
apiService = Substitute.for<ApiService>();
|
||||||
|
i18nService = Substitute.for<I18nService>();
|
||||||
|
collectionService = Substitute.for<CollectionService>();
|
||||||
|
platformUtilsService = Substitute.for<PlatformUtilsService>();
|
||||||
|
cryptoService = Substitute.for<CryptoService>();
|
||||||
|
|
||||||
|
importService = new ImportService(
|
||||||
|
cipherService,
|
||||||
|
folderService,
|
||||||
|
apiService,
|
||||||
|
i18nService,
|
||||||
|
collectionService,
|
||||||
|
platformUtilsService,
|
||||||
|
cryptoService
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("getImporterInstance", () => {
|
||||||
|
describe("Get bitPasswordProtected importer", () => {
|
||||||
|
let importer: Importer;
|
||||||
|
const organizationId = Utils.newGuid();
|
||||||
|
const password = Utils.newGuid();
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
importer = importService.getImporter(
|
||||||
|
"bitwardenpasswordprotected",
|
||||||
|
organizationId,
|
||||||
|
password
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("returns an instance of BitwardenPasswordProtectedImporter", () => {
|
||||||
|
expect(importer).toBeInstanceOf(BitwardenPasswordProtectedImporter);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("has the appropriate organization Id", () => {
|
||||||
|
expect(importer.organizationId).toEqual(organizationId);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("has the appropriate password", () => {
|
||||||
|
expect(Object.entries(importer)).toEqual(jasmine.arrayContaining([["password", password]]));
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
Reference in New Issue
Block a user