bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 08:13:42 +00:00
Code Issues Releases Wiki Activity

[EC-522] Improve handling of rxjs subjects (#3772)

Browse Source 
* [EC-522] feat: no public rxjs subjects

* [EC-522] feat: improve null handling

* [EC-552] fix: init subject with empty set instead of null

* [EC-552] fix: don't push null into account subject

* [EC-522] feat: remove null filter
This commit is contained in:
Andreas Coroiu
2022-11-01 11:25:46 +01:00
committed by GitHub
parent 4c9cddd639
commit 7b8507cf9b
15 changed files with 42 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/browser/src/decorators/session-sync-observable/browser-session.decorator.spec.ts
View File

@@ -38,7 +38,7 @@ describe("browserSession decorator", () => {
@browserSession
class TestClass {
@sessionSync({ initializer: (s: string) => s })
behaviorSubject = new BehaviorSubject("");
private behaviorSubject = new BehaviorSubject("");
constructor(private stateService: StateService) {}

8
apps/browser/src/decorators/session-sync-observable/session-sync.decorator.spec.ts
View File

@@ -7,7 +7,11 @@ describe("sessionSync decorator", () => {
const ctor = String;
class TestClass {
@sessionSync({ ctor: ctor, initializer: initializer })
testProperty = new BehaviorSubject("");
private testProperty = new BehaviorSubject("");
complete() {
this.testProperty.complete();
}
}
it("should add __syncedItemKeys to prototype", () => {
@@ -19,7 +23,7 @@ describe("sessionSync decorator", () => {
ctor: ctor,
initializer: initializer,
}),
testClass.testProperty.complete(),
testClass.complete(),
]);
});
});

4
apps/browser/src/popup/vault/vault-select.component.ts
View File

@@ -54,12 +54,12 @@ export class VaultSelectComponent implements OnInit, OnDestroy {
buttonRef: ElementRef<HTMLButtonElement>;
@ViewChild("vaultSelectorTemplate", { read: TemplateRef }) templateRef: TemplateRef<HTMLElement>;
private _selectedVault = new BehaviorSubject<string>(null);
private _selectedVault = new BehaviorSubject<string | null>(null);
isOpen = false;
loaded = false;
organizations$: Observable<Organization[]>;
selectedVault$: Observable<string> = this._selectedVault.asObservable();
selectedVault$: Observable<string | null> = this._selectedVault.asObservable();
vaultFilter: VaultFilter = new VaultFilter();
enforcePersonalOwnership = false;