bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-19 17:53:39 +00:00
Code Issues Releases Wiki Activity

[EC-522] Improve handling of rxjs subjects (#3772)

Browse Source 
* [EC-522] feat: no public rxjs subjects

* [EC-522] feat: improve null handling

* [EC-552] fix: init subject with empty set instead of null

* [EC-552] fix: don't push null into account subject

* [EC-522] feat: remove null filter
This commit is contained in:
Andreas Coroiu
2022-11-01 11:25:46 +01:00
committed by GitHub
parent 4c9cddd639
commit 7b8507cf9b
15 changed files with 42 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/desktop/src/app/layout/account-switcher.component.ts
View File

@@ -97,7 +97,7 @@ export class AccountSwitcherComponent implements OnInit, OnDestroy {
) {}
async ngOnInit(): Promise<void> {
this.stateService.accounts
this.stateService.accounts$
.pipe(
concatMap(async (accounts: { [userId: string]: Account }) => {
for (const userId in accounts) {

2
apps/desktop/src/app/layout/search/search-bar.service.ts
View File

@@ -8,7 +8,7 @@ export type SearchBarState = {
@Injectable()
export class SearchBarService {
private searchTextSubject = new BehaviorSubject<string>(null);
private searchTextSubject = new BehaviorSubject<string | null>(null);
searchText$ = this.searchTextSubject.asObservable();
private _state = {