From 7f1c68a24d1a3fa6d230f9400b4d6e8e5638f652 Mon Sep 17 00:00:00 2001 From: Mike Amirault Date: Mon, 2 Feb 2026 13:10:28 -0500 Subject: [PATCH] [PM-30675] Fix certain data fields being incorrect in account-restricted exports (#18531) --- libs/common/src/models/export/fido2-credential.export.ts | 8 +++++--- libs/common/src/models/export/login.export.ts | 6 +++++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/libs/common/src/models/export/fido2-credential.export.ts b/libs/common/src/models/export/fido2-credential.export.ts index ce9c754fea3..46131a67060 100644 --- a/libs/common/src/models/export/fido2-credential.export.ts +++ b/libs/common/src/models/export/fido2-credential.export.ts @@ -75,7 +75,7 @@ export class Fido2CredentialExport { domain.userDisplayName = req.userDisplayName != null ? new EncString(req.userDisplayName) : null; domain.discoverable = req.discoverable != null ? new EncString(req.discoverable) : null; - domain.creationDate = req.creationDate; + domain.creationDate = req.creationDate != null ? new Date(req.creationDate) : null; return domain; } @@ -111,10 +111,12 @@ export class Fido2CredentialExport { this.rpId = safeGetString(o.rpId); this.userHandle = safeGetString(o.userHandle); this.userName = safeGetString(o.userName); - this.counter = safeGetString(String(o.counter)); + this.counter = safeGetString(o instanceof Fido2CredentialView ? String(o.counter) : o.counter); this.rpName = safeGetString(o.rpName); this.userDisplayName = safeGetString(o.userDisplayName); - this.discoverable = safeGetString(String(o.discoverable)); + this.discoverable = safeGetString( + o instanceof Fido2CredentialView ? String(o.discoverable) : o.discoverable, + ); this.creationDate = o.creationDate; } } diff --git a/libs/common/src/models/export/login.export.ts b/libs/common/src/models/export/login.export.ts index b727c614bdf..9d926e5ede5 100644 --- a/libs/common/src/models/export/login.export.ts +++ b/libs/common/src/models/export/login.export.ts @@ -39,7 +39,11 @@ export class LoginExport { domain.username = req.username != null ? new EncString(req.username) : null; domain.password = req.password != null ? new EncString(req.password) : null; domain.totp = req.totp != null ? new EncString(req.totp) : null; - // Fido2credentials are currently not supported for exports. + if (req.fido2Credentials != null) { + domain.fido2Credentials = req.fido2Credentials.map((f2) => + Fido2CredentialExport.toDomain(f2), + ); + } return domain; }