From 7fd3d05598d6cba448df6cb006e176a1db9ef48a Mon Sep 17 00:00:00 2001 From: Patrick Pimentel Date: Thu, 17 Apr 2025 13:48:09 -0400 Subject: [PATCH] feat(extension-notification-demo): Fixed more nits. --- apps/browser/src/background/main.background.ts | 2 +- libs/angular/src/services/jslib-services.module.ts | 4 ++-- .../chrome-browser-extension-auth-request-approval.service.ts | 2 +- .../browser-system-notification.service.ts | 2 +- libs/common/src/platform/system-notifications/index.ts | 3 +-- ...-service.abstraction.ts => system-notification-service.ts} | 0 .../unsupported-system-notification.service.ts | 2 +- 7 files changed, 7 insertions(+), 8 deletions(-) rename libs/common/src/platform/system-notifications/{system-notification-service.abstraction.ts => system-notification-service.ts} (100%) diff --git a/apps/browser/src/background/main.background.ts b/apps/browser/src/background/main.background.ts index ea0a3c323e0..6435b95ef6a 100644 --- a/apps/browser/src/background/main.background.ts +++ b/apps/browser/src/background/main.background.ts @@ -173,7 +173,7 @@ import { SyncService } from "@bitwarden/common/platform/sync"; // eslint-disable-next-line no-restricted-imports -- Needed for service creation import { DefaultSyncService } from "@bitwarden/common/platform/sync/internal"; import { BrowserSystemNotificationService } from "@bitwarden/common/platform/system-notifications/browser-system-notification.service"; -import { SystemNotificationServiceAbstraction } from "@bitwarden/common/platform/system-notifications/system-notification-service.abstraction"; +import { SystemNotificationServiceAbstraction } from "@bitwarden/common/platform/system-notifications/system-notification-service"; import { DefaultThemeStateService } from "@bitwarden/common/platform/theming/theme-state.service"; import { ApiService } from "@bitwarden/common/services/api.service"; import { AuditService } from "@bitwarden/common/services/audit.service"; diff --git a/libs/angular/src/services/jslib-services.module.ts b/libs/angular/src/services/jslib-services.module.ts index 3355d070e78..a74382ad98e 100644 --- a/libs/angular/src/services/jslib-services.module.ts +++ b/libs/angular/src/services/jslib-services.module.ts @@ -243,8 +243,8 @@ import { StateEventRunnerService } from "@bitwarden/common/platform/state/state- import { SyncService } from "@bitwarden/common/platform/sync"; // eslint-disable-next-line no-restricted-imports -- Needed for DI import { DefaultSyncService } from "@bitwarden/common/platform/sync/internal"; -import { UnsupportedSystemNotificationService } from "@bitwarden/common/platform/system-notifications"; -import { SystemNotificationServiceAbstraction } from "@bitwarden/common/platform/system-notifications/system-notification-service.abstraction"; +import { SystemNotificationServiceAbstraction } from "@bitwarden/common/platform/system-notifications/system-notification-service"; +import { UnsupportedSystemNotificationService } from "@bitwarden/common/platform/system-notifications/unsupported-system-notification.service"; import { DefaultThemeStateService, ThemeStateService, diff --git a/libs/common/src/auth/services/devices/chrome-browser-extension-auth-request-approval.service.ts b/libs/common/src/auth/services/devices/chrome-browser-extension-auth-request-approval.service.ts index 9579716e39f..644d56e9c14 100644 --- a/libs/common/src/auth/services/devices/chrome-browser-extension-auth-request-approval.service.ts +++ b/libs/common/src/auth/services/devices/chrome-browser-extension-auth-request-approval.service.ts @@ -7,7 +7,7 @@ import { SystemNotificationServiceAbstraction, SystemNotificationEvent, ButtonLocation, -} from "@bitwarden/common/platform/system-notifications/system-notification-service.abstraction"; +} from "@bitwarden/common/platform/system-notifications/system-notification-service"; export abstract class AuthRequestLoginApprovalAbstraction { abstract receivedPendingAuthRequest(notificationId: string): Promise; diff --git a/libs/common/src/platform/system-notifications/browser-system-notification.service.ts b/libs/common/src/platform/system-notifications/browser-system-notification.service.ts index 576a5dfe664..d21ee8fac0e 100644 --- a/libs/common/src/platform/system-notifications/browser-system-notification.service.ts +++ b/libs/common/src/platform/system-notifications/browser-system-notification.service.ts @@ -9,7 +9,7 @@ import { SystemNotificationCreateInfo, SystemNotificationEvent, SystemNotificationServiceAbstraction as SystemNotificationServiceAbstraction, -} from "@bitwarden/common/platform/system-notifications/system-notification-service.abstraction"; +} from "@bitwarden/common/platform/system-notifications/system-notification-service"; export class BrowserSystemNotificationService implements SystemNotificationServiceAbstraction { private systemNotificationClickedSubject = new Subject(); diff --git a/libs/common/src/platform/system-notifications/index.ts b/libs/common/src/platform/system-notifications/index.ts index fff5f1e276c..c03863b8ceb 100644 --- a/libs/common/src/platform/system-notifications/index.ts +++ b/libs/common/src/platform/system-notifications/index.ts @@ -1,2 +1 @@ -export * from "./system-notification-service.abstraction"; -export * from "./unsupported-system-notification.service"; +export * from "./system-notification-service"; diff --git a/libs/common/src/platform/system-notifications/system-notification-service.abstraction.ts b/libs/common/src/platform/system-notifications/system-notification-service.ts similarity index 100% rename from libs/common/src/platform/system-notifications/system-notification-service.abstraction.ts rename to libs/common/src/platform/system-notifications/system-notification-service.ts diff --git a/libs/common/src/platform/system-notifications/unsupported-system-notification.service.ts b/libs/common/src/platform/system-notifications/unsupported-system-notification.service.ts index debb1b8fbc3..c11c4ad6070 100644 --- a/libs/common/src/platform/system-notifications/unsupported-system-notification.service.ts +++ b/libs/common/src/platform/system-notifications/unsupported-system-notification.service.ts @@ -5,7 +5,7 @@ import { SystemNotificationCreateInfo, SystemNotificationEvent, SystemNotificationServiceAbstraction as SystemNotificationServiceAbstraction, -} from "@bitwarden/common/platform/system-notifications/system-notification-service.abstraction"; +} from "@bitwarden/common/platform/system-notifications/system-notification-service"; export class UnsupportedSystemNotificationService implements SystemNotificationServiceAbstraction { private systemNotificationClickedSubject = new Subject();