From 814e43999bef4c233e58ed6a59ca0579046d0c7f Mon Sep 17 00:00:00 2001 From: Kyle Spearrin Date: Mon, 3 Dec 2018 11:16:26 -0500 Subject: [PATCH] Math.round getBoundingClientRect values. resolves #792 --- jslib | 2 +- src/popup/components/pop-out.component.ts | 4 ++-- src/popup/main.ts | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/jslib b/jslib index 739d308498a..5609fecbcee 160000 --- a/jslib +++ b/jslib @@ -1 +1 @@ -Subproject commit 739d308498ab68df3e37772265733c81b27f2cc2 +Subproject commit 5609fecbcee6d0608ea28985c31688511e735a59 diff --git a/src/popup/components/pop-out.component.ts b/src/popup/components/pop-out.component.ts index 2464ef8989c..e9ad1ec93af 100644 --- a/src/popup/components/pop-out.component.ts +++ b/src/popup/components/pop-out.component.ts @@ -56,8 +56,8 @@ export class PopOutComponent implements OnInit { chrome.windows.create({ url: href, type: 'popup', - width: bodyRect.width ? bodyRect.width + 60 : 375, - height: bodyRect.height || 600, + width: Math.round(bodyRect.width ? bodyRect.width + 60 : 375), + height: Math.round(bodyRect.height || 600), }); if (this.popupUtilsService.inPopup(window)) { diff --git a/src/popup/main.ts b/src/popup/main.ts index 09431ac642b..cea09777b33 100644 --- a/src/popup/main.ts +++ b/src/popup/main.ts @@ -21,8 +21,8 @@ function init() { chrome.windows.create({ url: 'popup/index.html?uilocation=popout', type: 'popup', - width: bodyRect.width + 60, - height: bodyRect.height, + width: Math.round(bodyRect.width + 60), + height: Math.round(bodyRect.height), }); BrowserApi.closePopup(window); return;