From 819c28600bc7d760f2e1e54f3c92e664bf0b4781 Mon Sep 17 00:00:00 2001 From: voommen-livefront Date: Wed, 5 Nov 2025 11:38:38 -0600 Subject: [PATCH] PM-27739 fixed type errors --- .../services/domain/risk-insights-orchestrator.service.ts | 2 +- .../risk-insights/services/view/risk-insights-data.service.ts | 2 +- .../all-applications/all-applications.component.ts | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/domain/risk-insights-orchestrator.service.ts b/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/domain/risk-insights-orchestrator.service.ts index a2c61e05913..7df84fb033f 100644 --- a/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/domain/risk-insights-orchestrator.service.ts +++ b/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/domain/risk-insights-orchestrator.service.ts @@ -84,7 +84,7 @@ export class RiskInsightsOrchestratorService { // ------------------------- Cipher data ------------------------- private _ciphersSubject = new BehaviorSubject(null); private _ciphers$ = this._ciphersSubject.asObservable(); - get ciphers$(): Observable { + get ciphers$(): Observable { return this._ciphers$; } diff --git a/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/view/risk-insights-data.service.ts b/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/view/risk-insights-data.service.ts index 2ea5a16c93a..f249c8267d6 100644 --- a/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/view/risk-insights-data.service.ts +++ b/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/view/risk-insights-data.service.ts @@ -39,7 +39,7 @@ export class RiskInsightsDataService { readonly isGeneratingReport$: Observable = of(false); readonly criticalReportResults$: Observable = of(null); readonly hasCiphers$: Observable = of(null); - readonly ciphers$: Observable = of([]); + readonly ciphers$: Observable = of(null); // New applications that need review (reviewedDate === null) readonly newApplications$: Observable = of([]); diff --git a/bitwarden_license/bit-web/src/app/dirt/access-intelligence/all-applications/all-applications.component.ts b/bitwarden_license/bit-web/src/app/dirt/access-intelligence/all-applications/all-applications.component.ts index abe03f716b4..919fbf1ac9b 100644 --- a/bitwarden_license/bit-web/src/app/dirt/access-intelligence/all-applications/all-applications.component.ts +++ b/bitwarden_license/bit-web/src/app/dirt/access-intelligence/all-applications/all-applications.component.ts @@ -80,13 +80,13 @@ export class AllApplicationsComponent implements OnInit { .pipe( switchMap(([report, ciphers]) => { if (!report) { - return null; + return of(null); } // Map ciphers to each application const reportWithCiphers = report.reportData.map((app) => ({ ...app, - ciphers: ciphers.filter((cipher) => app.cipherIds.includes(cipher.id)), + ciphers: ciphers?.filter((cipher) => app.cipherIds.includes(cipher.id)) ?? [], })); return of({ ...report, reportData: reportWithCiphers }); }),