bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-22 19:23:52 +00:00
Code Issues Releases Wiki Activity

[Refactor] Use rxjs first instead of unsubscribe from queryParams (#2112)

Browse Source 
* Use rxjs first instead of unsubscribe

* Update jslib
This commit is contained in:
Thomas Rittson
2021-10-15 07:58:59 +10:00
committed by GitHub
parent 2c2de6a233
commit 82138a08ff
13 changed files with 37 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/popup/vault/share.component.ts
View File

@@ -5,6 +5,8 @@ import {
Router,
} from '@angular/router';
import { first } from 'rxjs/operators';
import { CipherService } from 'jslib-common/abstractions/cipher.service';
import { CollectionService } from 'jslib-common/abstractions/collection.service';
import { I18nService } from 'jslib-common/abstractions/i18n.service';
@@ -29,12 +31,9 @@ export class ShareComponent extends BaseShareComponent {
this.onSharedCipher.subscribe(() => {
this.router.navigate(['view-cipher', { cipherId: this.cipherId }]);
});
const queryParamsSub = this.route.queryParams.subscribe(async params => {
this.route.queryParams.pipe(first()).subscribe(async params => {
this.cipherId = params.cipherId;
await this.load();
if (queryParamsSub != null) {
queryParamsSub.unsubscribe();
}
});
}