bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 08:43:33 +00:00
Code Issues Releases Wiki Activity

[Refactor] Use rxjs first instead of unsubscribe from queryParams (#2112)

Browse Source 
* Use rxjs first instead of unsubscribe

* Update jslib
This commit is contained in:
Thomas Rittson
2021-10-15 07:58:59 +10:00
committed by GitHub
parent 2c2de6a233
commit 82138a08ff
13 changed files with 37 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/popup/vault/view.component.ts
View File

@@ -9,6 +9,8 @@ import {
Router,
} from '@angular/router';
import { first } from 'rxjs/operators';
import { ApiService } from 'jslib-common/abstractions/api.service';
import { AuditService } from 'jslib-common/abstractions/audit.service';
import { CipherService } from 'jslib-common/abstractions/cipher.service';
@@ -65,7 +67,7 @@ export class ViewComponent extends BaseViewComponent {
ngOnInit() {
this.inPopout = this.popupUtilsService.inPopout(window);
const queryParamsSub = this.route.queryParams.subscribe(async params => {
this.route.queryParams.pipe(first()).subscribe(async params => {
if (params.cipherId) {
this.cipherId = params.cipherId;
} else {
@@ -73,9 +75,6 @@ export class ViewComponent extends BaseViewComponent {
}
await this.load();
if (queryParamsSub != null) {
queryParamsSub.unsubscribe();
}
});
super.ngOnInit();