mirror of
https://github.com/bitwarden/browser
synced 2025-12-17 00:33:44 +00:00
[PM-15847] libs/components strict migration (#15738)
This PR migrates `libs/components` to use strict TypeScript. - Remove `@ts-strict-ignore` from each file in `libs/components` and resolved any new compilation errors - Converted ViewChild and ContentChild decorators to use the new signal-based queries using the [Angular signal queries migration](https://angular.dev/reference/migrations/signal-queries) - Made view/content children `required` where appropriate, eliminating the need for additional null checking. This helped simplify the strict migration. --- Co-authored-by: Vicki League <vleague@bitwarden.com>
This commit is contained in:
@@ -1,6 +1,4 @@
|
||||
// FIXME: Update this file to be type safe and remove this and next line
|
||||
// @ts-strict-ignore
|
||||
import { Directive, HostListener, model, Optional, inject, DestroyRef } from "@angular/core";
|
||||
import { DestroyRef, Directive, HostListener, inject, model, Optional } from "@angular/core";
|
||||
import { takeUntilDestroyed } from "@angular/core/rxjs-interop";
|
||||
import { BehaviorSubject, finalize, tap } from "rxjs";
|
||||
|
||||
@@ -38,7 +36,7 @@ export class BitActionDirective {
|
||||
|
||||
disabled = false;
|
||||
|
||||
readonly handler = model<FunctionReturningAwaitable>(undefined, { alias: "bitAction" });
|
||||
readonly handler = model.required<FunctionReturningAwaitable>({ alias: "bitAction" });
|
||||
|
||||
private readonly destroyRef = inject(DestroyRef);
|
||||
|
||||
|
||||
@@ -1,6 +1,4 @@
|
||||
// FIXME: Update this file to be type safe and remove this and next line
|
||||
// @ts-strict-ignore
|
||||
import { Directive, OnInit, Optional, input, inject, DestroyRef } from "@angular/core";
|
||||
import { DestroyRef, Directive, OnInit, Optional, inject, input } from "@angular/core";
|
||||
import { takeUntilDestroyed } from "@angular/core/rxjs-interop";
|
||||
import { FormGroupDirective } from "@angular/forms";
|
||||
import { BehaviorSubject, catchError, filter, of, switchMap } from "rxjs";
|
||||
@@ -22,7 +20,7 @@ export class BitSubmitDirective implements OnInit {
|
||||
private _loading$ = new BehaviorSubject<boolean>(false);
|
||||
private _disabled$ = new BehaviorSubject<boolean>(false);
|
||||
|
||||
readonly handler = input<FunctionReturningAwaitable>(undefined, { alias: "bitSubmit" });
|
||||
readonly handler = input.required<FunctionReturningAwaitable>({ alias: "bitSubmit" });
|
||||
|
||||
readonly allowDisabledFormSubmit = input<boolean>(false);
|
||||
|
||||
@@ -63,7 +61,7 @@ export class BitSubmitDirective implements OnInit {
|
||||
|
||||
ngOnInit(): void {
|
||||
this.formGroupDirective.statusChanges
|
||||
.pipe(takeUntilDestroyed(this.destroyRef))
|
||||
?.pipe(takeUntilDestroyed(this.destroyRef))
|
||||
.subscribe((c) => {
|
||||
if (this.allowDisabledFormSubmit()) {
|
||||
this._disabled$.next(false);
|
||||
|
||||
@@ -1,5 +1,3 @@
|
||||
// FIXME: Update this file to be type safe and remove this and next line
|
||||
// @ts-strict-ignore
|
||||
import { Directive, Optional, input } from "@angular/core";
|
||||
import { takeUntilDestroyed } from "@angular/core/rxjs-interop";
|
||||
|
||||
|
||||
Reference in New Issue
Block a user