mirror of
https://github.com/bitwarden/browser
synced 2025-12-17 16:53:34 +00:00
[PM-15847] libs/components strict migration (#15738)
This PR migrates `libs/components` to use strict TypeScript. - Remove `@ts-strict-ignore` from each file in `libs/components` and resolved any new compilation errors - Converted ViewChild and ContentChild decorators to use the new signal-based queries using the [Angular signal queries migration](https://angular.dev/reference/migrations/signal-queries) - Made view/content children `required` where appropriate, eliminating the need for additional null checking. This helped simplify the strict migration. --- Co-authored-by: Vicki League <vleague@bitwarden.com>
This commit is contained in:
@@ -1,6 +1,3 @@
|
||||
// FIXME: Update this file to be type safe and remove this and next line
|
||||
// @ts-strict-ignore
|
||||
|
||||
import { NgClass } from "@angular/common";
|
||||
import {
|
||||
AfterContentChecked,
|
||||
@@ -8,8 +5,8 @@ import {
|
||||
Component,
|
||||
ElementRef,
|
||||
signal,
|
||||
ViewChild,
|
||||
input,
|
||||
viewChild,
|
||||
} from "@angular/core";
|
||||
|
||||
import { TypographyModule } from "../typography";
|
||||
@@ -30,7 +27,7 @@ import { TypographyModule } from "../typography";
|
||||
changeDetection: ChangeDetectionStrategy.OnPush,
|
||||
})
|
||||
export class ItemContentComponent implements AfterContentChecked {
|
||||
@ViewChild("endSlot") endSlot: ElementRef<HTMLDivElement>;
|
||||
readonly endSlot = viewChild<ElementRef<HTMLDivElement>>("endSlot");
|
||||
|
||||
protected endSlotHasChildren = signal(false);
|
||||
|
||||
@@ -42,6 +39,6 @@ export class ItemContentComponent implements AfterContentChecked {
|
||||
readonly truncate = input(true);
|
||||
|
||||
ngAfterContentChecked(): void {
|
||||
this.endSlotHasChildren.set(this.endSlot?.nativeElement.childElementCount > 0);
|
||||
this.endSlotHasChildren.set((this.endSlot()?.nativeElement.childElementCount ?? 0) > 0);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user