mirror of
https://github.com/bitwarden/browser
synced 2025-12-21 02:33:46 +00:00
[PM-15847] libs/components strict migration (#15738)
This PR migrates `libs/components` to use strict TypeScript. - Remove `@ts-strict-ignore` from each file in `libs/components` and resolved any new compilation errors - Converted ViewChild and ContentChild decorators to use the new signal-based queries using the [Angular signal queries migration](https://angular.dev/reference/migrations/signal-queries) - Made view/content children `required` where appropriate, eliminating the need for additional null checking. This helped simplify the strict migration. --- Co-authored-by: Vicki League <vleague@bitwarden.com>
This commit is contained in:
@@ -1,5 +1,3 @@
|
||||
// FIXME: Update this file to be type safe and remove this and next line
|
||||
// @ts-strict-ignore
|
||||
import { coerceBooleanProperty } from "@angular/cdk/coercion";
|
||||
import { NgClass } from "@angular/common";
|
||||
import { Component, HostBinding, OnInit, input } from "@angular/core";
|
||||
@@ -26,7 +24,7 @@ export class SortableComponent implements OnInit {
|
||||
/**
|
||||
* Mark the column as sortable and specify the key to sort by
|
||||
*/
|
||||
readonly bitSortable = input<string>();
|
||||
readonly bitSortable = input.required<string>();
|
||||
|
||||
readonly default = input(false, {
|
||||
transform: (value: SortDirection | boolean | "") => {
|
||||
@@ -63,7 +61,7 @@ export class SortableComponent implements OnInit {
|
||||
if (!this.isActive) {
|
||||
return undefined;
|
||||
}
|
||||
return this.sort.direction === "asc" ? "ascending" : "descending";
|
||||
return this.sort?.direction === "asc" ? "ascending" : "descending";
|
||||
}
|
||||
|
||||
protected setActive() {
|
||||
|
||||
Reference in New Issue
Block a user